From: Chuck Lever III <chuck.lever@oracle.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
"kernel-tls-handshake@lists.linux.dev"
<kernel-tls-handshake@lists.linux.dev>
Subject: Re: [PATCH v9 3/3] net/handshake: Add Kunit tests for the handshake consumer API
Date: Sat, 15 Apr 2023 17:57:56 +0000 [thread overview]
Message-ID: <ECA36DAF-F928-4EBD-9CD0-3AA20C2612FF@oracle.com> (raw)
In-Reply-To: <ZDocVvsqKJ57c1Tk@manet.1015granger.net>
> On Apr 14, 2023, at 11:39 PM, Chuck Lever <cel@kernel.org> wrote:
>
> On Fri, Apr 14, 2023 at 07:15:42PM -0700, Jakub Kicinski wrote:
>> On Fri, 14 Apr 2023 22:06:59 -0400 Chuck Lever wrote:
>>> On Fri, Apr 14, 2023 at 06:31:13PM -0700, Jakub Kicinski wrote:
>>>> We're getting:
>>>>
>>>> net/handshake/.kunitconfig: warning: ignored by one of the .gitignore files
>>>>
>>>> during allmodconfig build, any idea where that's coming from?
>>>
>>> As far as I know, all of the .kunitconfig files in the kernel tree
>>> are marked "ignored". I'm not sure why, nor if it's a significant
>>> problem.
>>
>> To be clear - no idea what the problem is but I don't think all
>> of them are:
>>
>> $ echo a > fs/fat/.kunitconfig
>> $ echo b > mm/kfence/.kunitconfig
>> $ echo c > net/sunrpc/.kunitconfig
>> $ git status
>> Changes not staged for commit:
>> (use "git add <file>..." to update what will be committed)
>> (use "git restore <file>..." to discard changes in working directory)
>> modified: fs/fat/.kunitconfig
>> modified: mm/kfence/.kunitconfig
>> modified: net/sunrpc/.kunitconfig
>
> The "ignored" list I got from the bot yesterday indeed included
> net/sunrpc/.kunitconfig as well as net/handshake/.kunitconfig, but
> git doesn't actually seem to ignore changes to these files, as you
> demonstrate here.
>
> I don't see a specific pattern in the kernel's .gitconfig that
> would exclude .kunitconfig files from change tracking.
>
> I can see where this warning might introduce false negative build
> results, but so far I haven't heard that particular complaint about
> net/sunrpc/.kunitconfig.
>
> Again, I wasn't sure if this was a significant problem or simply
> noise, so I haven't chased it. If someone on-list has insight,
> please speak up. I can try to have a look at it tomorrow.
OK, shedding a little light on this:
[cel@oracle-102 linux]$ git check-ignore -v .kunitconfig
.gitignore:13:.* .kunitconfig
[cel@oracle-102 linux]$ git status --ignored
On branch upcall-v10
Ignored files:
(use "git add -f <file>..." to include in what will be committed)
.kunit/
cscope.in.out
cscope.out
cscope.po.out
tools/net/ynl/lib/__pycache__/
tools/testing/kunit/__pycache__/
nothing to commit, working tree clean
[cel@oracle-102 linux]$
So,
a) There's a very broad wildcard pattern in .gitignore that
matches all dotfiles, and
b) git actually does not ignore .kunitconfig files.
I'm wondering if this might help the overall situation:
diff --git a/.gitignore b/.gitignore
index 70ec6037fa7a..51117ba29c88 100644
--- a/.gitignore
+++ b/.gitignore
@@ -105,6 +105,7 @@ modules.order
!.gitignore
!.mailmap
!.rustfmt.toml
+!.kunitconfig
#
# Generated include files
--
Chuck Lever
prev parent reply other threads:[~2023-04-15 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 19:13 [PATCH v9 0/3] Another crack at a handshake upcall mechanism Chuck Lever
2023-04-13 19:13 ` [PATCH v9 1/3] net/handshake: Create a NETLINK service for handling handshake requests Chuck Lever
2023-04-13 19:14 ` [PATCH v9 2/3] net/handshake: Add a kernel API for requesting a TLSv1.3 handshake Chuck Lever
2023-04-13 19:14 ` [PATCH v9 3/3] net/handshake: Add Kunit tests for the handshake consumer API Chuck Lever
2023-04-15 1:31 ` Jakub Kicinski
2023-04-15 2:06 ` Chuck Lever
2023-04-15 2:15 ` Jakub Kicinski
2023-04-15 3:39 ` Chuck Lever
2023-04-15 17:57 ` Chuck Lever III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ECA36DAF-F928-4EBD-9CD0-3AA20C2612FF@oracle.com \
--to=chuck.lever@oracle.com \
--cc=edumazet@google.com \
--cc=kernel-tls-handshake@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).