RE: [PATCH iwl-next v4 02/10] ice: Add driver support for firmware changes for LAG

["Ertman, David M" <david.m.ertman@intel.com>]

> -----Original Message-----
> From: Brett Creeley <bcreeley@amd.com>
> Sent: Wednesday, June 14, 2023 2:24 PM
> To: Ertman, David M <david.m.ertman@intel.com>; intel-wired-
> lan@lists.osuosl.org
> Cc: daniel.machon@microchip.com; simon.horman@corigine.com;
> netdev@vger.kernel.org
> Subject: Re: [PATCH iwl-next v4 02/10] ice: Add driver support for firmware
> changes for LAG
> 
> On 6/9/2023 2:16 PM, Dave Ertman wrote:
> > Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> >
> >
> > Add the defines, fields, and detection code for FW support of LAG for
> > SRIOV.  Also exposes some previously static functions to allow access
> > in the lag code.
> >
> > Clean up code that is unused or not needed for LAG support.  Also add
> > an ordered workqueue for processing LAG events.
> >
> > Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
> > Signed-off-by: Dave Ertman <david.m.ertman@intel.com>

...

> > +/**
> > + * ice_lag_check_nvm_support - Check for NVM support for LAG
> > + * @pf: PF struct
> > + */
> > +static void ice_lag_check_nvm_support(struct ice_pf *pf)
> 
> Nit, but this name is a bit misleading to me. I would expect it to be
> called something like "ice_lag_init_feature_support_flag()" or something
> similar that better describes what the function is doing.

Name changed

> 
> > +{
> > +       struct ice_hw_dev_caps *caps;
> > +
> > +       caps = &pf->hw.dev_caps;
> 
> Nit, but since you are already creating a local variable you could go
> one level further to the common_cap, so it could be:
> 
> common_cap->roce_lag and common_cap->sriov_lag

Variable changed to go down one mor level.

Changes to come out in v5
DaveE
> 
> > +       if (caps->common_cap.roce_lag)
> > +               ice_set_feature_support(pf, ICE_F_ROCE_LAG);
> > +       else
> > +               ice_clear_feature_support(pf, ICE_F_ROCE_LAG);
> > +
> > +       if (caps->common_cap.sriov_lag)
> > +               ice_set_feature_support(pf, ICE_F_SRIOV_LAG);
> > +       else
> > +               ice_clear_feature_support(pf, ICE_F_SRIOV_LAG);
> > +}
> > +
> 
> [...]
>