From: Andrew Lunn <andrew@lunn.ch>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next v2 02/17] net: mdio: ipq8064: switch to write/readl function
Date: Mon, 3 May 2021 16:44:58 +0200 [thread overview]
Message-ID: <YJAMavCyVxYERJPK@lunn.ch> (raw)
In-Reply-To: <YJAHj/IWZLEZeDmL@Ansuel-xps.localdomain>
On Mon, May 03, 2021 at 04:24:15PM +0200, Ansuel Smith wrote:
> On Mon, May 03, 2021 at 02:49:34PM +0200, Andrew Lunn wrote:
> > On Mon, May 03, 2021 at 01:06:54AM +0200, Ansuel Smith wrote:
> > > Use readl/writel function instead of regmap function to make sure no
> > > value is cached and align to other similar mdio driver.
> >
> > regmap is O.K. to use, so long as you tell it not to cache. Look at
> > how to use volatile in regmap.
> >
> > You might be able to follow what lan9303_mdio.c is doing.
> >
> > Andrew
>
> Was thinking more about the overhead of using regmap instead of plain
> writel. Or is it minimal?
It is likely other parts of the system are using regmap. So it will
not be adding much overhead.
Andrew
next prev parent reply other threads:[~2021-05-03 14:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-02 23:06 [RFC PATCH net-next v2 01/17] net: mdio: ipq8064: clean whitespaces in define Ansuel Smith
2021-05-02 23:06 ` [RFC PATCH net-next v2 02/17] net: mdio: ipq8064: switch to write/readl function Ansuel Smith
2021-05-03 12:49 ` Andrew Lunn
2021-05-03 14:24 ` Ansuel Smith
2021-05-03 14:44 ` Andrew Lunn [this message]
2021-05-02 23:06 ` [RFC PATCH net-next v2 03/17] net: mdio: ipq8064: enlarge sleep after read/write operation Ansuel Smith
2021-05-02 23:06 ` [RFC PATCH net-next v2 04/17] net: dsa: qca8k: rework read/write/set_page to provide error Ansuel Smith
2021-05-02 23:06 ` [RFC PATCH net-next v2 05/17] net: dsa: qca8k: add support for qca8327 switch Ansuel Smith
2021-05-02 23:06 ` [RFC PATCH net-next v2 06/17] devicetree: net: dsa: qca8k: Document new compatible qca8327 Ansuel Smith
2021-05-02 23:06 ` [RFC PATCH net-next v2 07/17] net: dsa: qca8k: add priority tweak to qca8337 switch Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 08/17] net: dsa: qca8k: add GLOBAL_FC settings needed for qca8327 Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 09/17] net: dsa: qca8k: add support for switch rev Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 10/17] net: dsa: qca8k: make rgmii delay configurable Ansuel Smith
2021-05-03 0:54 ` Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 11/17] net: dsa: qca8k: clear MASTER_EN after phy read/write Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 12/17] net: dsa: qca8k: dsa: qca8k: protect MASTER busy_wait with mdio mutex Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 13/17] net: dsa: qca8k: enlarge mdio delay and timeout Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 14/17] net: phy: phylink: permit to pass dev_flags to phylink_connect_phy Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 15/17] net: dsa: slave: pass dev_flags also to internal PHY Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 16/17] net: dsa: qca8k: pass switch_revision info to phy dev_flags Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 17/17] net: phy: add qca8k driver for qca8k switch internal PHY Ansuel Smith
2021-05-02 23:07 ` [RFC PATCH net-next v2 00/17] Multiple improvement to qca8k stability Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJAMavCyVxYERJPK@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).