From: Andrew Lunn <andrew@lunn.ch>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, kuba@kernel.org, linux@armlinux.org.uk,
jaz@semihalf.com, gjb@semihalf.com, upstream@semihalf.com,
Samer.El-Haj-Mahmoud@arm.com, jon@solid-run.com
Subject: Re: [net-next: PATCH 1/3] net: mvmdio: add ACPI support
Date: Sun, 13 Jun 2021 21:20:07 +0200 [thread overview]
Message-ID: <YMZaZx3oZ7tYCEPH@lunn.ch> (raw)
In-Reply-To: <20210613183520.2247415-2-mw@semihalf.com>
> - ret = of_mdiobus_register(bus, pdev->dev.of_node);
> + if (pdev->dev.of_node)
> + ret = of_mdiobus_register(bus, pdev->dev.of_node);
> + else if (is_acpi_node(pdev->dev.fwnode))
> + ret = acpi_mdiobus_register(bus, pdev->dev.fwnode);
> + else
> + ret = -EINVAL;
This seems like something which could be put into fwnode_mdio.c.
Andrew
next prev parent reply other threads:[~2021-06-13 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 18:35 [net-next: PATCH 0/3] ACPI MDIO support for Marvell controllers Marcin Wojtas
2021-06-13 18:35 ` [net-next: PATCH 1/3] net: mvmdio: add ACPI support Marcin Wojtas
2021-06-13 19:20 ` Andrew Lunn [this message]
2021-06-15 15:13 ` Marcin Wojtas
2021-06-15 19:53 ` Andy Shevchenko
2021-06-13 19:34 ` Andrew Lunn
[not found] ` <CAHp75VdMsYJMCwH2o14e7nJBTj6A38dkcZJ+0WQfnW=keOyoAg@mail.gmail.com>
2021-06-15 15:09 ` Marcin Wojtas
2021-06-15 19:50 ` Andy Shevchenko
2021-06-13 18:35 ` [net-next: PATCH 2/3] net: mvpp2: enable using phylink with ACPI Marcin Wojtas
2021-06-13 18:44 ` Russell King (Oracle)
2021-06-13 20:53 ` Marcin Wojtas
2021-06-13 19:47 ` Andrew Lunn
2021-06-13 21:21 ` Marcin Wojtas
2021-06-13 21:35 ` Andrew Lunn
2021-06-13 23:46 ` Marcin Wojtas
2021-06-14 0:08 ` Andrew Lunn
2021-06-13 18:35 ` [net-next: PATCH 3/3] net: mvpp2: remove unused 'has_phy' field Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMZaZx3oZ7tYCEPH@lunn.ch \
--to=andrew@lunn.ch \
--cc=Samer.El-Haj-Mahmoud@arm.com \
--cc=davem@davemloft.net \
--cc=gjb@semihalf.com \
--cc=jaz@semihalf.com \
--cc=jon@solid-run.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=upstream@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).