From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1] netdevsim: Forbid devlink reload when adding or deleting ports
Date: Thu, 5 Aug 2021 17:33:35 +0300 [thread overview]
Message-ID: <YQv2v5cTqLvoPc4n@unreal> (raw)
In-Reply-To: <20210805072342.17faf851@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Aug 05, 2021 at 07:23:42AM -0700, Jakub Kicinski wrote:
> On Thu, 5 Aug 2021 16:51:31 +0300 Leon Romanovsky wrote:
> > > > + nsim_bus_dev = nsim_dev->nsim_bus_dev;
> > > > + if (!mutex_trylock(&nsim_bus_dev->nsim_bus_reload_lock))
> > > > + return -EOPNOTSUPP;
> > >
> > > Why not -EBUSY?
> >
> > This is what devlink_reload_disable() returns, so I kept same error.
> > It is not important at all.
> >
> > What about the following change on top of this patch?
>
> LGTM, the only question is whether we should leave in_reload true
> if nsim_dev->fail_reload is set.
I don't think so, it will block add/delete ports.
>
> > @@ -889,17 +890,26 @@ static int nsim_dev_reload_up(struct devlink *devlink, enum devlink_reload_actio
> > struct netlink_ext_ack *extack)
> > {
> > struct nsim_dev *nsim_dev = devlink_priv(devlink);
> > + struct nsim_bus_dev *nsim_bus_dev;
> > + int ret;
> > +
> > + nsim_bus_dev = nsim_dev->nsim_bus_dev;
> > + mutex_lock(&nsim_bus_dev->nsim_bus_reload_lock);
> > + nsim_bus_dev->in_reload = false;
> >
> > if (nsim_dev->fail_reload) {
> > /* For testing purposes, user set debugfs fail_reload
> > * value to true. Fail right away.
> > */
> > NL_SET_ERR_MSG_MOD(extack, "User setup the reload to fail for testing purposes");
> > + mutex_unlock(&nsim_bus_dev->nsim_bus_reload_lock);
> > return -EINVAL;
> > }
> >
> > *actions_performed = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT);
> > - return nsim_dev_reload_create(nsim_dev, extack);
> > + ret = nsim_dev_reload_create(nsim_dev, extack);
> > + mutex_unlock(&nsim_bus_dev->nsim_bus_reload_lock);
> > + return ret;
> > }
>
>
next prev parent reply other threads:[~2021-08-05 14:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 11:02 [PATCH net-next] netdevsim: Forbid devlink reload when adding or deleting ports Leon Romanovsky
2021-08-05 11:05 ` [PATCH net-next v1] " Leon Romanovsky
2021-08-05 12:40 ` [PATCH net-next] " patchwork-bot+netdevbpf
2021-08-05 13:15 ` [PATCH net-next v1] " Jakub Kicinski
2021-08-05 13:51 ` Leon Romanovsky
2021-08-05 14:23 ` Jakub Kicinski
2021-08-05 14:33 ` Leon Romanovsky [this message]
2021-08-05 15:27 ` Jakub Kicinski
2021-08-05 17:35 ` Leon Romanovsky
2021-08-05 18:02 ` Leon Romanovsky
2021-08-05 19:12 ` Jakub Kicinski
2021-08-06 11:19 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQv2v5cTqLvoPc4n@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).