netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH net-next] sock: add sndbuff full perf trace event
Date: Sun, 23 Jan 2022 12:17:36 -0800	[thread overview]
Message-ID: <Ye234Pb0f1SusMbA@pop-os.localdomain> (raw)
In-Reply-To: <1642716150-100589-1-git-send-email-jdamato@fastly.com>

On Thu, Jan 20, 2022 at 02:02:30PM -0800, Joe Damato wrote:
> Calls to sock_alloc_send_pskb can fail or trigger a wait if there is no
> sndbuf space available.
> 
> Add a perf trace event to help users monitor when and how this occurs so
> appropriate application level changes can be made, if necessary.
> 
> Signed-off-by: Joe Damato <jdamato@fastly.com>
> ---
>  include/trace/events/sock.h | 21 +++++++++++++++++++++
>  net/core/sock.c             |  1 +
>  2 files changed, 22 insertions(+)

There are more places where we set the SOCKWQ_ASYNC_NOSPACE bit, so
it looks like your patch is incomplete.

Thanks.

  reply	other threads:[~2022-01-23 20:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-20 22:02 [PATCH net-next] sock: add sndbuff full perf trace event Joe Damato
2022-01-23 20:17 ` Cong Wang [this message]
2022-01-25 19:51   ` Joe Damato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ye234Pb0f1SusMbA@pop-os.localdomain \
    --to=xiyou.wangcong@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jdamato@fastly.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).