From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3BE5C433FE for ; Wed, 19 Jan 2022 09:19:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352980AbiASJTP (ORCPT ); Wed, 19 Jan 2022 04:19:15 -0500 Received: from mga12.intel.com ([192.55.52.136]:61815 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352693AbiASJTL (ORCPT ); Wed, 19 Jan 2022 04:19:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642583951; x=1674119951; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Zf7maaT407OcqJiMSYXoEAzMcLY861f8NYGTlKtPnGA=; b=YkalItov6WCXDDbUVKKK5aiMjxJxH7VjKeBum4WvbO6/eIILTB8TVBJw jRCxXXVexNuFXe7vS7MNJ6i/X4Yr+VXupmXNUNrECWFoZIzkBepGSqWw4 yra6STdVm4jTib3jLzsdVfV7+Lrqx9pj3CQ8cR5EmMeagU4MlmkKoHH85 5cqCu828qtI5h+4xugHrJy1z8tTYl4NE8N1FgJNRRB2GpXvaucEd6IDMH xoEjc5zSBaX34fbfXHRQmOWwjcQ/gvsOwidLRd5fdoDcVqTwyPqi1fw9Z FnwI4Ke+m92A92TKLrLxpYChlXf3f9lyFUIz6G/FF/LoqsfAt2B3teJxK A==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="225001669" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="225001669" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:11 -0800 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="622447667" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:01 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id CEBE0203C8; Wed, 19 Jan 2022 11:18:59 +0200 (EET) Date: Wed, 19 Jan 2022 11:18:59 +0200 From: Sakari Ailus To: Lucas De Marchi Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-security-module@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, Alex Deucher , Andrew Morton , Andy Shevchenko , Andy Shevchenko , Ben Skeggs , Christian =?iso-8859-1?Q?K=F6nig?= , Chris Wilson , Daniel Vetter , David Airlie , "David S . Miller" , Emma Anholt , Eryk Brol , Francis Laniel , Greg Kroah-Hartman , Harry Wentland , Jakub Kicinski , Jani Nikula , Joonas Lahtinen , Julia Lawall , Kentaro Takeda , Leo Li , Mikita Lipski , Petr Mladek , Rahul Lakkireddy , Raju Rangoju , Rasmus Villemoes , Rodrigo Vivi , Sergey Senozhatsky , Steven Rostedt , Vishal Kulkarni Subject: Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation Message-ID: References: <20220119072450.2890107-1-lucas.demarchi@intel.com> <20220119072450.2890107-2-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220119072450.2890107-2-lucas.demarchi@intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Lucas, On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, > case 3: > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) > tomoyo_io_printf(head, " grant_log=%s", > - tomoyo_yesno(cond->grant_log == > - TOMOYO_GRANTLOG_YES)); > + yesno(cond->grant_log == TOMOYO_GRANTLOG_YES)); This would be better split on two lines. Then, Reviewed-by: Sakari Ailus -- Sakari Ailus