From: Breno Leitao <leitao@debian.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
sergey.senozhatsky@gmail.com, pmladek@suse.com,
Dave Jones <davej@codemonkey.org.uk>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] netconsole: Append kernel version to message
Date: Tue, 4 Jul 2023 08:53:56 -0700 [thread overview]
Message-ID: <ZKRAlJMi3tjOSrXD@gmail.com> (raw)
In-Reply-To: <4b2746ad-1835-43e6-a2fc-7063735daa46@lunn.ch>
On Mon, Jul 03, 2023 at 06:46:25PM +0200, Andrew Lunn wrote:
> Hi Breno
Hello,
> Why not just send the message without uname appended. You probably
> want to see the OOM messages...
>
> Also, what context are we in here? Should that be GFP_ATOMIC, which
> net/core/netpoll.c is using to allocate the skbs?
Maybe this is not necessary anymore, since I might be using the buffer
already allocated.
> > +static inline void send_msg_udp(struct netconsole_target *nt,
> > + const char *msg, unsigned int len)
> > +{
> > +#ifdef CONFIG_NETCONSOLE_UNAME
> > + send_ext_msg_udp_uname(nt, msg, len);
> > +#else
> > + send_ext_msg_udp(nt, msg, len);
> > +#endif
>
> Please use
>
> if (IS_ENABLED(CONFIG_NETCONSOLE_UNAME)) {} else {}
>
> so the code is compiled and then thrown away. That nakes build testing
> more efficient.
Makes total sense, I am incorporating it into v2 now.
Thanks!
next prev parent reply other threads:[~2023-07-04 15:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 15:41 [PATCH] netconsole: Append kernel version to message leitao
2023-07-03 16:46 ` Andrew Lunn
2023-07-04 15:53 ` Breno Leitao [this message]
2023-07-03 18:34 ` Stephen Hemminger
2023-07-04 15:15 ` Breno Leitao
2023-07-04 15:58 ` Stephen Hemminger
2023-07-05 9:18 ` Breno Leitao
2023-07-05 15:26 ` Stephen Hemminger
2023-07-05 15:49 ` Jakub Kicinski
2023-07-03 19:44 ` Jakub Kicinski
2023-07-04 15:47 ` Breno Leitao
2023-07-05 15:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKRAlJMi3tjOSrXD@gmail.com \
--to=leitao@debian.org \
--cc=andrew@lunn.ch \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).