From: Jiri Pirko <jiri@resnulli.us>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Willem de Bruijn <willemb@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
syzbot+7f4d0ea3df4d4fa9a65f@syzkaller.appspotmail.com
Subject: Re: [PATCH net] net: add more sanity check in virtio_net_hdr_to_skb()
Date: Fri, 12 Jan 2024 16:44:17 +0100 [thread overview]
Message-ID: <ZaFeUZ6F4hWUu4FU@nanopsycho> (raw)
In-Reply-To: <CANn89iLam6JDbJ3NJ3cRs1fnDz2HAN_gMhAn0SewoYbqBLbW4w@mail.gmail.com>
Fri, Jan 12, 2024 at 02:11:43PM CET, edumazet@google.com wrote:
>On Fri, Jan 12, 2024 at 2:00 PM Jiri Pirko <jiri@resnulli.us> wrote:
>>
>> Fri, Jan 12, 2024 at 01:28:16PM CET, edumazet@google.com wrote:
>> >syzbot/KMSAN reports access to uninitialized data from gso_features_check() [1]
>> >
>> >The repro use af_packet, injecting a gso packet and hdrlen == 0.
>> >
>> >We could fix the issue making gso_features_check() more careful
>> >while dealing with NETIF_F_TSO_MANGLEID in fast path.
>> >
>> >Or we can make sure virtio_net_hdr_to_skb() pulls minimal network and
>> >transport headers as intended.
>>
>> You describe "either or", but don't really say what to do. Bit
>> confusing :/
>
>Not sure I understand your point?
>
> Patch title is " net: add more sanity check in virtio_net_hdr_to_skb() ",
>and the change is implementing that option.
Right. Patch desctiption does not clearly say it, that's what made me
wonder.
>
>I am saying I prefer not touching gso_features_check(), even if we
>could just do this.
>
>Had I been silent about that option, I am sure some reviewers would
>have raised the question,
>given the stack trace ?
>
>Apparently you are saying these kinds of things should not be ever mentioned,
>because of some "imperative mood" request that you often raise with my patches.
I woudn't dare :) I just find it hard to understand from time to time,
sorry about that.
>
>I have not written a novel, only one sentence, admittedly not written
>in perfect English.
next prev parent reply other threads:[~2024-01-12 15:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 12:28 [PATCH net] net: add more sanity check in virtio_net_hdr_to_skb() Eric Dumazet
2024-01-12 13:00 ` Jiri Pirko
2024-01-12 13:11 ` Eric Dumazet
2024-01-12 15:44 ` Jiri Pirko [this message]
2024-01-12 16:41 ` Willem de Bruijn
2024-01-13 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZaFeUZ6F4hWUu4FU@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+7f4d0ea3df4d4fa9a65f@syzkaller.appspotmail.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).