From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Paul Moore <paul@paul-moore.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
netdev@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: [PATCH net-next] netlabel: Reorder fields in 'struct netlbl_domaddr6_map'
Date: Sun, 18 Jun 2023 12:16:41 +0200 [thread overview]
Message-ID: <aa109847260e51e174c823b6d1441f75be370f01.1687083361.git.christophe.jaillet@wanadoo.fr> (raw)
Group some variables based on their sizes to reduce hole and avoid padding.
On x86_64, this shrinks the size of 'struct netlbl_domaddr6_map'
from 72 to 64 bytes.
It saves a few bytes of memory and is more cache-line friendly.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Using pahole
Before:
======
struct netlbl_dom_map {
char * domain; /* 0 8 */
u16 family; /* 8 2 */
/* XXX 6 bytes hole, try to pack */
struct netlbl_dommap_def def; /* 16 16 */
u32 valid; /* 32 4 */
/* XXX 4 bytes hole, try to pack */
struct list_head list; /* 40 16 */
struct callback_head rcu __attribute__((__aligned__(8))); /* 56 16 */
/* size: 72, cachelines: 2, members: 6 */
/* sum members: 62, holes: 2, sum holes: 10 */
/* forced alignments: 1 */
/* last cacheline: 8 bytes */
} __attribute__((__aligned__(8)));
After:
=====
struct netlbl_dom_map {
char * domain; /* 0 8 */
struct netlbl_dommap_def def; /* 8 16 */
u16 family; /* 24 2 */
/* XXX 2 bytes hole, try to pack */
u32 valid; /* 28 4 */
struct list_head list; /* 32 16 */
struct callback_head rcu __attribute__((__aligned__(8))); /* 48 16 */
/* size: 64, cachelines: 1, members: 6 */
/* sum members: 62, holes: 1, sum holes: 2 */
/* forced alignments: 1 */
} __attribute__((__aligned__(8)));
---
net/netlabel/netlabel_domainhash.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netlabel/netlabel_domainhash.h b/net/netlabel/netlabel_domainhash.h
index 9f80972ae39b..7eaa35fdd9bd 100644
--- a/net/netlabel/netlabel_domainhash.h
+++ b/net/netlabel/netlabel_domainhash.h
@@ -57,8 +57,8 @@ struct netlbl_domaddr6_map {
struct netlbl_dom_map {
char *domain;
- u16 family;
struct netlbl_dommap_def def;
+ u16 family;
u32 valid;
struct list_head list;
--
2.34.1
next reply other threads:[~2023-06-18 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-18 10:16 Christophe JAILLET [this message]
2023-06-19 14:08 ` [PATCH net-next] netlabel: Reorder fields in 'struct netlbl_domaddr6_map' Simon Horman
2023-06-19 14:43 ` Jiri Pirko
2023-06-19 16:06 ` Paul Moore
2023-06-21 3:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa109847260e51e174c823b6d1441f75be370f01.1687083361.git.christophe.jaillet@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).