From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Lawrence Brakmo <brakmo@fb.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH][bpf-next] bpf: verifier: add a break statement in switch
Date: Wed, 19 Jun 2019 13:46:05 -0500 [thread overview]
Message-ID: <ac7c8305-efc5-ffb6-f8a2-9595b2e06197@embeddedor.com> (raw)
In-Reply-To: <CAEf4BzbVWSd=xVHdbM1R_u_V_HA7DESdF=gL9aH76VC25oq1dg@mail.gmail.com>
On 6/19/19 12:44 PM, Andrii Nakryiko wrote:
> On Wed, Jun 19, 2019 at 9:07 AM Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>>
>> Notice that in this case, it's much clearer to explicitly add a break
>> rather than letting the code to fall through. It also avoid potential
>> future fall-through warnings[1].
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> [1] https://lore.kernel.org/patchwork/patch/1087056/
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>
> Acked-by: Andrii Nakryiko <andriin@fb.com>
>
Thanks, Andrii.
--
Gustavo
prev parent reply other threads:[~2019-06-19 18:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 16:07 [PATCH][bpf-next] bpf: verifier: add a break statement in switch Gustavo A. R. Silva
2019-06-19 17:44 ` Andrii Nakryiko
2019-06-19 18:46 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac7c8305-efc5-ffb6-f8a2-9595b2e06197@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brakmo@fb.com \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).