From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FAE9C33CB2 for ; Thu, 30 Jan 2020 01:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F31E020661 for ; Thu, 30 Jan 2020 01:21:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727198AbgA3BVw (ORCPT ); Wed, 29 Jan 2020 20:21:52 -0500 Received: from mga17.intel.com ([192.55.52.151]:9156 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726618AbgA3BVv (ORCPT ); Wed, 29 Jan 2020 20:21:51 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2020 17:21:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,380,1574150400"; d="scan'208";a="428152425" Received: from cmossx-mobl1.amr.corp.intel.com ([10.251.7.89]) by fmsmga005.fm.intel.com with ESMTP; 29 Jan 2020 17:21:51 -0800 Date: Wed, 29 Jan 2020 17:21:51 -0800 (PST) From: Mat Martineau X-X-Sender: mjmartin@cmossx-mobl1.amr.corp.intel.com To: Linus Torvalds cc: David Miller , Paolo Abeni , Christoph Paasch , Andrew Morton , Netdev , Geert Uytterhoeven Subject: Re: [GIT] Networking In-Reply-To: Message-ID: References: <20200128.172544.1405211638887784147.davem@davemloft.net> User-Agent: Alpine 2.22 (OSX 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 29 Jan 2020, Linus Torvalds wrote: > On Tue, Jan 28, 2020 at 8:26 AM David Miller wrote: >> >> 12) Add initial support for MPTCP protocol, from Christoph Paasch, >> Matthieu Baerts, Florian Westphal, Peter Krystad, and many >> others. > > Hmm. This adds a MPTCP_HMAC_TEST config variable, and while it is > "default n" (which is redundant - 'n' is the default anyway), it > should likely instead be "depends on MPTCP". > > Because right now, if you say no to MPTCP, it will _still_ ask you > about MPTCP_HMAC_TEST, which makes no sense. Even if you were to say > 'y', there won't be any tests done since MPTCP isn't built at all. > Thanks for noting this. A fix is on the way: https://patchwork.ozlabs.org/patch/1231045/ -- Mat Martineau Intel