netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: wenxu <wenxu@ucloud.cn>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: fw@strlen.de, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH nf-next v2 2/2] netfilter: nft_meta: Add NFT_META_BRI_VLAN support
Date: Wed, 26 Jun 2019 20:42:27 +0800	[thread overview]
Message-ID: <b037a0a9-4729-41ff-81bb-ca76c0e3fba9@ucloud.cn> (raw)
In-Reply-To: <20190626102935.ztxcfb3kysvohzi3@salvia>

I agree with you, It's a more generic way to set the vlan tag not base on

any bridge. I will resubmit NFT_META_BRI_VLAN_PROTO and

NFT_META_VLAN patches

在 2019/6/26 18:29, Pablo Neira Ayuso 写道:
> Could you add a NFT_META_BRI_VLAN_PROTO? Similar to patch 1/2, to
> retrieve p->br->vlan_proto.
>
> Then, add a generic way to set the vlan metadata. I'm attaching an
> incomplete patch, so there is something like:
>
>         meta vlan set 0x88a8:20
>
> to set q-in-q.
>
> we could also add a shortcut for simple vlan case (no q-in-q), ie.
> assuming protocol is 0x8100:
>
>         meta vlan set 20
>
> Does this make sense to you?
>
> And we have a way to set the meta vlan information from ingress to
> then, which is something I also need here.
>
> Thanks.

  reply	other threads:[~2019-06-26 12:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20  1:17 [PATCH nf-next v2 1/2] netfilter: nft_meta: add NFT_META_BRI_PVID support wenxu
2019-06-20  1:17 ` [PATCH nf-next v2 2/2] netfilter: nft_meta: Add NFT_META_BRI_VLAN support wenxu
2019-06-26  9:01   ` Pablo Neira Ayuso
2019-06-26 10:29   ` Pablo Neira Ayuso
2019-06-26 12:42     ` wenxu [this message]
2019-06-26 12:57       ` Pablo Neira Ayuso
2019-06-25  9:23 ` [PATCH nf-next v2 1/2] netfilter: nft_meta: add NFT_META_BRI_PVID support wenxu
2019-06-25  9:54   ` Pablo Neira Ayuso
2019-06-26  9:01 ` Pablo Neira Ayuso
2019-06-26 10:30   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b037a0a9-4729-41ff-81bb-ca76c0e3fba9@ucloud.cn \
    --to=wenxu@ucloud.cn \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).