From: Justin Chen <justin.chen@broadcom.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
netdev@vger.kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com,
florian.fainelli@broadcom.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, opendmb@gmail.com, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk, rafal@milecki.pl,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next resend 2/6] dt-bindings: net: brcm,asp-v2.0: Add asp-v2.2
Date: Mon, 26 Feb 2024 11:42:09 -0800 [thread overview]
Message-ID: <b6c74bbe-89f0-4201-b968-57996f0e0223@broadcom.com> (raw)
In-Reply-To: <b9164eae-69e2-44f3-8deb-e3a5180e459c@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]
On 2/24/24 2:22 AM, Krzysztof Kozlowski wrote:
> On 23/02/2024 23:24, Justin Chen wrote:
>> Add support for ASP 2.2.
>>
>> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
>> ---
>> Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> index 75d8138298fb..5a345f03de17 100644
>> --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
>> @@ -15,6 +15,10 @@ description: Broadcom Ethernet controller first introduced with 72165
>> properties:
>> compatible:
>> oneOf:
>> + - items:
>> + - enum:
>> + - brcm,bcm74165-asp
>> + - const: brcm,asp-v2.2
>> - items:
>> - enum:
>> - brcm,bcm74165-asp
>
> Hm, this confuses me: why do you have same SoC with three different
> versions of the same block?
>
bcm72165 -> asp-v2.0
bcm74165 -> asp-v2.1
Are two different SoCs.
The entry I just added is
bcm74165 -> asp-v2.2
This is a SoC minor revision. Maybe it should bcm74165b0-asp instead?
Not sure what the protocol is.
Thanks,
Justin
> Best regards,
> Krzysztof
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]
next prev parent reply other threads:[~2024-02-26 19:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 22:24 [PATCH net-next resend 0/6] Support for ASP 2.2 and optimizations Justin Chen
2024-02-23 22:24 ` [PATCH net-next resend 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.2 Justin Chen
2024-02-24 10:21 ` Krzysztof Kozlowski
2024-02-27 0:07 ` Florian Fainelli
2024-02-23 22:24 ` [PATCH net-next resend 2/6] dt-bindings: net: brcm,asp-v2.0: " Justin Chen
2024-02-24 10:22 ` Krzysztof Kozlowski
2024-02-26 19:42 ` Justin Chen [this message]
2024-02-27 6:55 ` Krzysztof Kozlowski
2024-02-27 7:07 ` Justin Chen
2024-02-27 11:45 ` Paolo Abeni
2024-02-27 0:07 ` Florian Fainelli
2024-02-23 22:24 ` [PATCH net-next resend 3/6] net: bcmasp: Add support for ASP 2.2 Justin Chen
2024-02-27 0:08 ` Florian Fainelli
2024-02-23 22:24 ` [PATCH net-next resend 4/6] net: phy: mdio-bcm-unimac: Add asp v2.2 support Justin Chen
2024-02-27 0:08 ` Florian Fainelli
2024-02-23 22:24 ` [PATCH net-next resend 5/6] net: bcmasp: Keep buffers through power management Justin Chen
2024-02-27 0:08 ` Florian Fainelli
2024-02-23 22:24 ` [PATCH net-next resend 6/6] net: bcmasp: Add support for PHY interrupts Justin Chen
2024-02-27 0:08 ` Florian Fainelli
2024-02-24 10:23 ` [PATCH net-next resend 0/6] Support for ASP 2.2 and optimizations Krzysztof Kozlowski
2024-02-26 19:46 ` Justin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c74bbe-89f0-4201-b968-57996f0e0223@broadcom.com \
--to=justin.chen@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).