From: Alex Elder <elder@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, evgreen@chromium.org,
subashab@codeaurora.org, cpratapa@codeaurora.org,
bjorn.andersson@linaro.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/3] net: ipa: no checksum offload for SDM845 LAN RX
Date: Mon, 29 Jun 2020 20:02:35 -0500 [thread overview]
Message-ID: <bada706f-779b-9a53-0d92-c0b79f99f723@linaro.org> (raw)
In-Reply-To: <20200629171046.4b3ed68c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On 6/29/20 7:10 PM, Jakub Kicinski wrote:
> On Mon, 29 Jun 2020 16:20:37 -0500 Alex Elder wrote:
>> The AP LAN RX endpoint should not have download checksum offload
>> enabled.
>>
>> The receive handler does properly accomodate the trailer that's
>> added by the hardware, but we ignore it.
>>
>> Signed-off-by: Alex Elder <elder@linaro.org>
>
> For this net series - would you mind adding Fixes tags to each patch?
Yes. That hasn't been my practice in the past; I guess I'll add
it to my checklist...
I will fix the spelling error in version 2.
-Alex
>
> Also checkpatch sayeth:
>
> WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'?
> #10:
> The receive handler does properly accomodate the trailer that's
>
next prev parent reply other threads:[~2020-06-30 1:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 21:20 [PATCH net 0/3] net: ipa: three bug fixes Alex Elder
2020-06-29 21:20 ` [PATCH net 1/3] net: ipa: always check for stopped channel Alex Elder
2020-06-29 21:20 ` [PATCH net 2/3] net: ipa: no checksum offload for SDM845 LAN RX Alex Elder
2020-06-30 0:10 ` Jakub Kicinski
2020-06-30 1:02 ` Alex Elder [this message]
2020-06-29 21:26 ` [PATCH net 3/3] net: ipa: introduce ipa_cmd_tag_process() Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bada706f-779b-9a53-0d92-c0b79f99f723@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).