From: David Laight <David.Laight@ACULAB.COM>
To: 'Marcelo Ricardo Leitner' <marcelo.leitner@gmail.com>,
Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
Neil Horman <nhorman@tuxdriver.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds
Date: Fri, 13 Sep 2019 08:36:22 +0000 [thread overview]
Message-ID: <bcaba726b7444efea7b14fcd60e4743a@AcuMS.aculab.com> (raw)
In-Reply-To: <20190912225154.GF3499@localhost.localdomain>
From: Marcelo Ricardo Leitner
> Sent: 12 September 2019 23:52
...
> Here it is more visible. If net->...ps_retrans is disabled, remaining
> fields (currently just this one, but as we are extending it now, we
> have to think about the possibility of more as well) will be ignored,
> we and we may not want that.
The only real way to add additional fields is to change the name
of the structure - that way recompiled programs still work.
You could require that programs zero the entire structure - but
that is difficult to verify.
And, in this case, it seems that the default has to be 0xffff
rather than 0 - which is, in itself, horrid.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2019-09-13 8:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 7:56 [PATCH net-next 0/5] sctp: update from rfc7829 Xin Long
2019-09-09 7:56 ` [PATCH net-next 1/5] sctp: add SCTP_ADDR_POTENTIALLY_FAILED notification Xin Long
2019-09-09 7:56 ` [PATCH net-next 2/5] sctp: add pf_expose per netns and sock and asoc Xin Long
2019-09-09 7:56 ` [PATCH net-next 3/5] sctp: add SCTP_EXPOSE_POTENTIALLY_FAILED_STATE sockopt Xin Long
2019-09-09 7:56 ` [PATCH net-next 4/5] sctp: add support for Primary Path Switchover Xin Long
2019-09-09 7:56 ` [PATCH net-next 5/5] sctp: add spt_pathcpthld in struct sctp_paddrthlds Xin Long
2019-09-10 13:19 ` David Laight
2019-09-11 8:51 ` Xin Long
2019-09-11 9:03 ` David Laight
2019-09-11 9:21 ` Xin Long
2019-09-11 9:38 ` Xin Long
2019-09-11 12:56 ` Marcelo Ricardo Leitner
2019-09-11 17:47 ` Xin Long
2019-09-12 22:51 ` Marcelo Ricardo Leitner
2019-09-13 8:36 ` David Laight [this message]
2019-09-13 13:19 ` 'Marcelo Ricardo Leitner'
2019-09-13 13:31 ` David Laight
2019-09-13 13:40 ` 'Marcelo Ricardo Leitner'
2019-09-10 17:27 ` David Miller
2019-09-11 8:14 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcaba726b7444efea7b14fcd60e4743a@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).