From: "lipeng (Y)" <lipeng321@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Guangbin Huang <huangguangbin2@huawei.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <xie.he.0141@gmail.com>, <ms@dev.tdt.de>,
<willemb@google.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 04/11] net: z85230: remove redundant initialization for statics
Date: Mon, 14 Jun 2021 21:03:56 +0800 [thread overview]
Message-ID: <bf51962d-b567-5d87-188a-6a0e4d79c670@huawei.com> (raw)
In-Reply-To: <YMdLYzr4QjrQIe0o@lunn.ch>
在 2021/6/14 20:28, Andrew Lunn 写道:
> On Mon, Jun 14, 2021 at 06:16:12PM +0800, lipeng (Y) wrote:
>> 在 2021/6/14 0:22, Andrew Lunn 写道:
>>
>> On Sun, Jun 13, 2021 at 03:38:16PM +0800, Guangbin Huang wrote:
>>
>> From: Peng Li <lipeng321@huawei.com>
>>
>> Should not initialise statics to 0.
>>
>> Signed-off-by: Peng Li <lipeng321@huawei.com>
>> Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
>> ---
>> drivers/net/wan/z85230.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wan/z85230.c b/drivers/net/wan/z85230.c
>> index 94ed9a2..f815bb5 100644
>> --- a/drivers/net/wan/z85230.c
>> +++ b/drivers/net/wan/z85230.c
>> @@ -685,7 +685,7 @@ irqreturn_t z8530_interrupt(int irq, void *dev_id)
>> {
>> struct z8530_dev *dev=dev_id;
>> u8 intr;
>> - static volatile int locker=0;
>> + static int locker;
>>
>> Is the volatile unneeded? Please document that in the commit message.
>>
>> Andrew
>> .
>>
>> Hi, Andrew:
>>
>> When i create this patch, it will WARNING: Use of volatile is usually wrong:
>> see Documentation/process/volatile-considered-harmful.rst
>>
>> According to the file in kernel: Documentation/process/volatile-considered-
>> harmful.rst
>>
>> the "volatile" type class should not be used.
>>
>> So i remove "volatile" in this patch.
> Please be very careful to explain exactly why it is wrong, in this
> specific case. You could also consider adding another patch which
> replaces the volatile with what is recommended.
>
> Andrew
> .
Hi, Andrew:
I will remove patch 04/11 from this clean-up patchset.
Will send another patch with detail reason for this line if needed.
Thanks for your comments.
Peng Li
next prev parent reply other threads:[~2021-06-14 13:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 7:38 [PATCH net-next 00/11] net: z85230: clean up some code style issues Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 01/11] net: z85230: remove redundant blank lines Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 02/11] net: z85230: add blank line after declarations Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 03/11] net: z85230: fix the code style issue about EXPORT_SYMBOL(foo) Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 04/11] net: z85230: remove redundant initialization for statics Guangbin Huang
2021-06-13 16:22 ` Andrew Lunn
2021-06-14 10:21 ` lipeng (Y)
[not found] ` <3b15d3bd-4116-ebed-ba86-13efbe7958f4@huawei.com>
2021-06-14 12:28 ` Andrew Lunn
2021-06-14 13:03 ` lipeng (Y) [this message]
2021-06-13 7:38 ` [PATCH net-next 05/11] net: z85230: replace comparison to NULL with "!skb" Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 06/11] net: z85230: fix the comments style issue Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 07/11] net: z85230: fix the code style issue about "if..else.." Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 08/11] net: z85230: remove trailing whitespaces Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 09/11] net: z85230: add some required spaces Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 10/11] net: z85230: fix the code style issue about open brace { Guangbin Huang
2021-06-13 7:38 ` [PATCH net-next 11/11] net: z85230: remove unnecessary out of memory message Guangbin Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf51962d-b567-5d87-188a-6a0e4d79c670@huawei.com \
--to=lipeng321@huawei.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=huangguangbin2@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).