From: William Tu <witu@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, jiri@nvidia.com, bodong@nvidia.com
Subject: Re: [PATCH net-next] Documentation: Add documentation for eswitch attribute
Date: Sun, 10 Mar 2024 08:10:10 -0700 [thread overview]
Message-ID: <c12687e1-88a3-4ad8-ac39-731a5724ae22@nvidia.com> (raw)
In-Reply-To: <20240308201435.2790b7b4@kernel.org>
On 3/8/24 8:14 PM, Jakub Kicinski wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, 8 Mar 2024 02:01:06 +0200 William Tu wrote:
>> + * - ``mode``
>> + - enum
>> + - The mode of the device. The mode can be one of the following:
>> +
>> + * ``legacy`` Legacy SRIOV.
>> + * ``switchdev`` SRIOV switchdev offloads.
> In my head `mode` is special because it controls on / off for
> switchdev, and none of the other attrs do anything outside of
> switchdev mode. But thinking about it now, I'm not sure if that's
> actually the case. Let's clarify. And if other attrs indeed are
> only meaningful in switchdev mode we should feature `mode` more
> prominently than others. Separate section perhaps?
got it, will check their dependencies and put in doc.
> Please link to representors.rst and perhaps switchdev.rst ?
> --
OK
William
prev parent reply other threads:[~2024-03-10 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 0:01 [PATCH net-next] Documentation: Add documentation for eswitch attribute William Tu
2024-03-09 4:14 ` Jakub Kicinski
2024-03-10 15:10 ` William Tu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c12687e1-88a3-4ad8-ac39-731a5724ae22@nvidia.com \
--to=witu@nvidia.com \
--cc=bodong@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).