netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Keguang Zhang <keguang.zhang@gmail.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>
Subject: Re: [PATCH v4 3/4] net: stmmac: Add glue layer for Loongson-1 SoC
Date: Mon, 11 Sep 2023 12:48:05 +0200	[thread overview]
Message-ID: <c94138d2-1bfa-2815-a766-b7904e35a86f@linaro.org> (raw)
In-Reply-To: <20230830134241.506464-4-keguang.zhang@gmail.com>

On 30/8/23 15:42, Keguang Zhang wrote:
> This glue driver is created based on the arch-code
> implemented earlier with the platform-specific settings.
> 
> Use syscon for SYSCON register access.
> 
> Partially based on the previous work by Serge Semin.
> 
> Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> V3 -> V4: Drop ls1x_dwmac_syscon definition and its instances
>            Drop three redundant fields from the ls1x_dwmac structure
>            Drop the ls1x_dwmac_init() method.
>            Some minor improvements
> V2 -> V3: Determine the device ID by physical
>            base address(suggested by Serge Semin)
>            Use regmap instead of regmap fields
>            Use syscon_regmap_lookup_by_phandle()
>            Some minor fixes
> V1 -> V2: Fix the build errors due to CONFIG_OF being unset
>            Change struct reg_field definitions to const
>            Rename the syscon property to "loongson,dwmac-syscon"
>            Add MII PHY mode for LS1C
> 
>   drivers/net/ethernet/stmicro/stmmac/Kconfig   |  11 +
>   drivers/net/ethernet/stmicro/stmmac/Makefile  |   1 +
>   .../ethernet/stmicro/stmmac/dwmac-loongson1.c | 219 ++++++++++++++++++
>   3 files changed, 231 insertions(+)
>   create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c

Squash:

-- >8 --
diff --git a/MAINTAINERS b/MAINTAINERS
index ff1f273b4f36..2519d06b5aab 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14344,9 +14344,12 @@ MIPS/LOONGSON1 ARCHITECTURE
  M:	Keguang Zhang <keguang.zhang@gmail.com>
  L:	linux-mips@vger.kernel.org
  S:	Maintained
  F:	Documentation/devicetree/bindings/*/loongson,ls1x-*.yaml
  F:	Documentation/devicetree/bindings/net/loongson,ls1*.yaml
  F:	arch/mips/include/asm/mach-loongson32/
  F:	arch/mips/loongson32/
  F:	drivers/*/*loongson1*
+F:	drivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c
---

  reply	other threads:[~2023-09-11 10:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 13:42 [PATCH v4 0/4] Move Loongson1 MAC arch-code to the driver dir Keguang Zhang
2023-08-30 13:42 ` [PATCH v4 1/4] dt-bindings: mfd: syscon: Add compatibles for Loongson-1 syscon Keguang Zhang
2023-08-30 13:42 ` [PATCH v4 2/4] dt-bindings: net: Add Loongson-1 Ethernet Controller Keguang Zhang
2023-09-11 10:47   ` Philippe Mathieu-Daudé
2023-09-12  2:00     ` Keguang Zhang
2023-08-30 13:42 ` [PATCH v4 3/4] net: stmmac: Add glue layer for Loongson-1 SoC Keguang Zhang
2023-09-11 10:48   ` Philippe Mathieu-Daudé [this message]
2023-09-12  2:01     ` Keguang Zhang
2023-09-12 10:11   ` Serge Semin
2023-09-14 10:30     ` Keguang Zhang
2023-08-30 13:42 ` [PATCH v4 4/4] MAINTAINERS: Update MIPS/LOONGSON1 entry Keguang Zhang
2023-08-31  8:40   ` Philippe Mathieu-Daudé
2023-08-31 11:01     ` Keguang Zhang
2023-09-11 10:46       ` Philippe Mathieu-Daudé
2023-08-31 11:51 ` [PATCH v4 0/4] Move Loongson1 MAC arch-code to the driver dir Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c94138d2-1bfa-2815-a766-b7904e35a86f@linaro.org \
    --to=philmd@linaro.org \
    --cc=Sergey.Semin@baikalelectronics.ru \
    --cc=alexandre.torgue@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=joabreu@synopsys.com \
    --cc=keguang.zhang@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peppe.cavallaro@st.com \
    --cc=robh+dt@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).