From: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
To: "kuba@kernel.org" <kuba@kernel.org>
Cc: "nhorman@redhat.com" <nhorman@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>,
"Patynowski, PrzemyslawX" <przemyslawx.patynowski@intel.com>,
"Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Bowers, AndrewX" <andrewx.bowers@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Subject: Re: [net 2/3] i40e: Set RX_ONLY mode for unicast promiscuous on VLAN
Date: Fri, 14 Aug 2020 21:39:13 +0000 [thread overview]
Message-ID: <ca1af30ab7b50a4d1aa078a6400fdb6cf4bb84a8.camel@intel.com> (raw)
In-Reply-To: <20200814141926.3a728c78@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, 2020-08-14 at 14:19 -0700, Jakub Kicinski wrote:
> On Fri, 14 Aug 2020 13:36:42 -0700 Tony Nguyen wrote:
> > + * @hw: pointer to the hw struct
> > + * @maj: api major value
> > + * @min: api minor value
> > +static bool i40e_is_aq_api_ver_ge(struct i40e_adminq_info *aq, u16
> > maj,
> > + u16 min)
>
> hw vs aq. Please build test the patches with W=1.
Will fix this and make sure to run W=1 on all the patches.
next prev parent reply other threads:[~2020-08-14 21:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 20:36 [net 0/3][pull request] Intel Wired LAN Driver Updates 2020-08-14 Tony Nguyen
2020-08-14 20:36 ` [net 1/3] igc: Fix PTP initialization Tony Nguyen
2020-08-14 20:36 ` [net 2/3] i40e: Set RX_ONLY mode for unicast promiscuous on VLAN Tony Nguyen
2020-08-14 21:19 ` Jakub Kicinski
2020-08-14 21:39 ` Nguyen, Anthony L [this message]
2020-08-14 20:36 ` [net 3/3] i40e: Fix crash during removing i40e driver Tony Nguyen
2020-08-14 21:20 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca1af30ab7b50a4d1aa078a6400fdb6cf4bb84a8.camel@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrewx.bowers@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=przemyslawx.patynowski@intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).