From: Jason Wang <jasowang@redhat.com>
To: David Miller <davem@davemloft.net>, yangyingliang@huawei.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
xiyou.wangcong@gmail.com, weiyongjun1@huawei.com
Subject: Re: [PATCH v3] tun: fix use-after-free when register netdev failed
Date: Tue, 20 Aug 2019 10:28:49 +0800 [thread overview]
Message-ID: <ceeafaf2-6aa4-b815-0b5f-ecc663216f43@redhat.com> (raw)
In-Reply-To: <20190819.182522.414877916903078544.davem@davemloft.net>
On 2019/8/20 上午9:25, David Miller wrote:
> From: Yang Yingliang <yangyingliang@huawei.com>
> Date: Mon, 19 Aug 2019 21:31:19 +0800
>
>> Call tun_attach() after register_netdevice() to make sure tfile->tun
>> is not published until the netdevice is registered. So the read/write
>> thread can not use the tun pointer that may freed by free_netdev().
>> (The tun and dev pointer are allocated by alloc_netdev_mqs(), they can
>> be freed by netdev_freemem().)
> register_netdevice() must always be the last operation in the order of
> network device setup.
>
> At the point register_netdevice() is called, the device is visible globally
> and therefore all of it's software state must be fully initialized and
> ready for us.
>
> You're going to have to find another solution to these problems.
The device is loosely coupled with sockets/queues. Each side is allowed
to be go away without caring the other side. So in this case, there's a
small window that network stack think the device has one queue but
actually not, the code can then safely drop them. Maybe it's ok here
with some comments?
Or if not, we can try to hold the device before tun_attach and drop it
after register_netdevice().
Thanks
next prev parent reply other threads:[~2019-08-20 2:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 13:31 [PATCH v3] tun: fix use-after-free when register netdev failed Yang Yingliang
2019-08-20 1:25 ` David Miller
2019-08-20 2:28 ` Jason Wang [this message]
2019-08-22 2:13 ` Jason Wang
2019-08-22 6:07 ` Yang Yingliang
2019-08-22 12:55 ` Yang Yingliang
2019-08-23 3:05 ` Jason Wang
2019-08-23 9:36 ` Yang Yingliang
2019-09-02 5:32 ` Jason Wang
2019-09-03 1:45 ` Yang Yingliang
2019-09-03 3:03 ` Jason Wang
2019-09-03 5:42 ` Yang Yingliang
2019-09-03 6:06 ` Jason Wang
2019-09-03 7:35 ` Yang Yingliang
2019-09-03 10:50 ` Jason Wang
2019-09-05 2:03 ` Yang Yingliang
2019-09-05 3:10 ` Jason Wang
2019-09-10 2:31 ` Yang Yingliang
2019-09-10 2:36 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ceeafaf2-6aa4-b815-0b5f-ecc663216f43@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).