netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roi Dayan <roid@mellanox.com>
To: Saeed Mahameed <saeedm@mellanox.com>,
	"wenxu@ucloud.cn" <wenxu@ucloud.cn>,
	Mark Bloch <markb@mellanox.com>, Paul Blakey <paulb@mellanox.com>,
	Vlad Buslov <vladbu@mellanox.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2] net/mlx5e: Add mlx5e_flower_parse_meta support
Date: Wed, 22 Jan 2020 08:50:26 +0000	[thread overview]
Message-ID: <cf04db18-a989-91a1-7a37-35b17dbe36ef@mellanox.com> (raw)
In-Reply-To: <fac29985c39902b1cb50426da02615285824dd6b.camel@mellanox.com>



On 2020-01-21 10:56 PM, Saeed Mahameed wrote:
> On Wed, 2020-01-15 at 08:51 +0000, Roi Dayan wrote:
>>
>> On 2020-01-15 1:58 AM, wenxu wrote:
>>>  2020/1/15 4:46, Saeed Mahameed :
>>>> Hi Wenxu,
>>>>
>>>> According to our regression Team, This commit is breaking vxlan
>>>> offload
>>>> CC'ed Paul, Roi and Vlad, they will assist you if you need any
>>>> help.
>>>>
>>>> can you please investigate the following call trace ?
>>>
>>> Hi Saeed & Paul,
>>>
>>>
>>> This patch just check the meta key match with the filter_dev.  If
>>> this match failed,
>>>
>>> The new flower install will failed and never allocate new
>>> mlx5_fs_ftes.
>>>
>>> How can I reproduce this case? Can you provide the test case
>>> script?
>>>
>>>
>>> BR
>>>
>>> wenxu
>>
>> Hi Saeed, Wenxu,
>>
>> I reviewed the patch and verified manually just in case. Such issue
>> should
>> not be reproduced from this patch and indeed I did not reproduce it.
>> I'll take the issue with our regression team.
>> I acked the patch. looks good to me.
>>
>> Thanks,
>> Roi
>>
>>
> 
> 
> Thanks Roi, 
> 
> If the discussion is over and you ack the patch, please provide a
> formal "Acked-by" tag so i will pull this patch into net-next-mlx5.
> 
> Thanks,
> Saeed.
> 

I thought I did. sorry.

Acked-by: Roi Dayan <roid@mellanox.com>

  reply	other threads:[~2020-01-22  8:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-07  9:16 [PATCH net-next v2] net/mlx5e: Add mlx5e_flower_parse_meta support wenxu
2020-01-14 20:46 ` Saeed Mahameed
2020-01-14 23:58   ` wenxu
2020-01-15  8:51     ` Roi Dayan
2020-01-21 20:56       ` Saeed Mahameed
2020-01-22  8:50         ` Roi Dayan [this message]
2020-01-22 19:17           ` Saeed Mahameed
2020-01-15  8:48 ` Roi Dayan
2020-01-15  9:13 ` Or Gerlitz
2020-01-15  9:37   ` wenxu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf04db18-a989-91a1-7a37-35b17dbe36ef@mellanox.com \
    --to=roid@mellanox.com \
    --cc=markb@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulb@mellanox.com \
    --cc=saeedm@mellanox.com \
    --cc=vladbu@mellanox.com \
    --cc=wenxu@ucloud.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).