From: Matt Johnston <matt@codeconstruct.com.au>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: linux-i3c@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: i3c: Add mctp-controller property
Date: Mon, 03 Jul 2023 16:14:16 +0800 [thread overview]
Message-ID: <d29fc42c04f2e1142b0a196ef7df2d74335cec2e.camel@codeconstruct.com.au> (raw)
In-Reply-To: <CAGE=qrrqE3Vj1Bs+cC51gKPDmsqMTyHEAJhsrGCyS_jYKf42Gw@mail.gmail.com>
On Mon, 2023-07-03 at 09:15 +0200, Krzysztof Kozlowski wrote:
> On Mon, 3 Jul 2023 at 07:31, Matt Johnston <matt@codeconstruct.com.au> wrote:
> >
> > This property is used to describe a I3C bus with attached MCTP I3C
> > target devices.
> >
> > Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
> > ---
> > Documentation/devicetree/bindings/i3c/i3c.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml
> > index fdb4212149e7..08731e2484f2 100644
> > --- a/Documentation/devicetree/bindings/i3c/i3c.yaml
> > +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml
> > @@ -55,6 +55,10 @@ properties:
> >
> > May not be supported by all controllers.
> >
> > + mctp-controller:
> > + description: |
> > + Indicates that this bus hosts MCTP-over-I3C target devices.
>
> I have doubts you actually tested it - there is no type/ref. Also,
> your description is a bit different than existing from dtschema. Why?
> Aren't these the same things?
(sorry my reply minutes ago was somehow an old draft, please ignore)
Ah, I'll add
$ref: /schemas/types.yaml#/definitions/flag
Testing with
make dtbs_check DT_SCHEMA_FILES=trivial-devices.yaml
I don't see any warnings, and neither after adding mctp-controller to a .dts
(out of tree) and testing with
make CHECK_DTBS=y DT_SCHEMA_FILES=i3c.yaml aspeed-test.dtb
Should that pick it up?
For the description, do you mean it differs to the other properties in
i3c.yaml, or something else?
Thanks,
Matt
next prev parent reply other threads:[~2023-07-03 8:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 5:30 [PATCH 0/3] I3C MCTP net driver Matt Johnston
2023-07-03 5:30 ` [PATCH 1/3] dt-bindings: i3c: Add mctp-controller property Matt Johnston
2023-07-03 7:15 ` Krzysztof Kozlowski
2023-07-03 8:03 ` Matt Johnston
2023-07-03 8:14 ` Matt Johnston [this message]
2023-07-03 14:16 ` Krzysztof Kozlowski
2023-07-04 6:34 ` Matt Johnston
2023-07-03 5:30 ` [PATCH 2/3] i3c: Add support for bus enumeration & notification Matt Johnston
2023-07-03 15:01 ` Krzysztof Kozlowski
2023-07-03 5:30 ` [PATCH 3/3] mctp i3c: MCTP I3C driver Matt Johnston
2023-07-03 11:48 ` David Miller
2023-07-03 14:43 ` Andrew Lunn
2023-07-04 6:49 ` Matt Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d29fc42c04f2e1142b0a196ef7df2d74335cec2e.camel@codeconstruct.com.au \
--to=matt@codeconstruct.com.au \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).