From: David Ahern <dsahern@kernel.org>
To: Dan Moulding <dan@danm.net>, alexhenrie24@gmail.com
Cc: bagasdotme@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com,
regressions@lists.linux.dev
Subject: Re: [REGRESSION] net/ipv6/addrconf: Temporary addresses with short lifetimes generating when they shouldn't, causing applications to fail
Date: Fri, 29 Dec 2023 15:52:00 -0700 [thread overview]
Message-ID: <d2f328c6-b5b4-46d0-b087-c70e2460d28a@kernel.org> (raw)
In-Reply-To: <20231229163339.2716-1-dan@danm.net>
On 12/29/23 11:33 AM, Dan Moulding wrote:
> I think a maintainer will probably need to make a call here and decide
> how to proceed.
>
>> TEMP_PREFERRED_LIFETIME is an administratively set variable: The user
>> can change it to whatever they want whenever they want, and the
>> operating system can adjust it automatically too.
>
> Agreed. And the behavior it seems you really want is to prevent the
> user from administratively setting it to a value that is lower than
> REGEN_ADVANCE, so that it won't stop generating new temporary
> addresses altogether.
>
> But preventing the user from configuring it to a value that is too low
> is different from generating new temporary addresses with preferred
> lifetimes that are greater than the currently configured value of
> TEMP_PREFERRED_LIFETIME. I still believe it would be better, and would
> be in conformance with the RFC, to simply not allow the user to
> configure a too-short TEMP_PREFERRED_LIFETIME instead of tinkering
> with the lifetimes of generated temporary addresses.
>
>> It's fine to revert the commit for version 6.7 (after all, I think
>> everyone wants a break for the holidays). Hopefully by version 6.8 we
>> can agree on a way to support users who want to randomize their IPv6
>> address as frequently as the network allows.
>
> FWIW, I think the desired effect you are seeking makes sense and is
> the right thing to do. I'm just not convinced this is the correct way
> to do it. But I'm not a maintainer and also not an expert in IPv6, so
> I'm definitely not the right person to make that call.
>
Send a revert before 6.7 is released which will most likely be this
weekend.
next prev parent reply other threads:[~2023-12-29 22:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 23:10 [REGRESSION] net/ipv6/addrconf: Temporary addresses with short lifetimes generating when they shouldn't, causing applications to fail Dan Moulding
2023-12-22 23:42 ` Alex Henrie
2023-12-22 23:42 ` [PATCH net] net: ipv6/addrconf: clamp temporary address's preferred lifetime to public address's Alex Henrie
2023-12-23 15:22 ` [REGRESSION] net/ipv6/addrconf: Temporary addresses with short lifetimes generating when they shouldn't, causing applications to fail Dan Moulding
2023-12-24 0:07 ` Alex Henrie
2023-12-29 16:33 ` Dan Moulding
2023-12-29 22:52 ` David Ahern [this message]
2023-12-30 4:32 ` [PATCH] Revert "net: ipv6/addrconf: clamp preferred_lft to the minimum required" Alex Henrie
2023-12-30 15:43 ` David Ahern
2024-01-02 23:10 ` patchwork-bot+netdevbpf
2023-12-30 4:12 ` [REGRESSION] net/ipv6/addrconf: Temporary addresses with short lifetimes generating when they shouldn't, causing applications to fail Alex Henrie
2023-12-23 8:42 ` Linux regression tracking #adding (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2f328c6-b5b4-46d0-b087-c70e2460d28a@kernel.org \
--to=dsahern@kernel.org \
--cc=alexhenrie24@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=dan@danm.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).