From: Tariq Toukan <tariqt@mellanox.com>
To: Matthew Wilcox <willy@infradead.org>, Tariq Toukan <tariqt@mellanox.com>
Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>,
David Miller <davem@davemloft.net>,
"brouer@redhat.com" <brouer@redhat.com>,
"toke@redhat.com" <toke@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t
Date: Mon, 11 Feb 2019 15:38:22 +0000 [thread overview]
Message-ID: <d3aae1c0-a9ac-b79d-fed9-0f57230167de@mellanox.com> (raw)
In-Reply-To: <20190211121208.GB12668@bombadil.infradead.org>
On 2/11/2019 2:12 PM, Matthew Wilcox wrote:
> On Mon, Feb 11, 2019 at 08:53:19AM +0000, Tariq Toukan wrote:
>> It's great to use the struct page to store its dma mapping, but I am
>> worried about extensibility.
>> page_pool is evolving, and it would need several more per-page fields.
>> One of them would be pageref_bias, a planned optimization to reduce the
>> number of the costly atomic pageref operations (and replace existing
>> code in several drivers).
>
> There's space for five words (20 or 40 bytes on 32/64 bit).
>
OK so this is good for now, and for the near future.
Fine by me.
Regards,
Tariq
next prev parent reply other threads:[~2019-02-11 15:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 14:36 [RFC, PATCH] net: page_pool: Don't use page->private to store dma_addr_t Ilias Apalodimas
2019-02-07 15:07 ` Matthew Wilcox
2019-02-07 15:20 ` Ilias Apalodimas
2019-02-07 21:25 ` David Miller
2019-02-07 21:34 ` Matthew Wilcox
2019-02-07 21:42 ` Ilias Apalodimas
2019-02-11 8:53 ` Tariq Toukan
2019-02-11 12:12 ` Matthew Wilcox
2019-02-11 15:38 ` Tariq Toukan [this message]
2019-02-11 17:14 ` Eric Dumazet
2019-02-12 12:39 ` Tariq Toukan
2019-02-12 13:49 ` Jesper Dangaard Brouer
2019-02-12 14:58 ` Tariq Toukan
2019-02-12 15:15 ` Eric Dumazet
2019-02-12 18:13 ` Alexander Duyck
2019-02-12 18:20 ` Ilias Apalodimas
2019-02-13 8:50 ` Tariq Toukan
2019-02-13 8:46 ` Tariq Toukan
2019-02-07 21:37 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3aae1c0-a9ac-b79d-fed9-0f57230167de@mellanox.com \
--to=tariqt@mellanox.com \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).