netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Coco Li <lixiaoyan@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
	Willem de Bruijn <willemb@google.com>,
	Tanner Love <tannerlove@google.com>
Subject: Re: [PATCH net-next 1/2] selftests/net: GRO coalesce test
Date: Fri, 06 Aug 2021 09:49:53 +0200	[thread overview]
Message-ID: <dea381f16949a076860a550ae1db91dcca935f8f.camel@redhat.com> (raw)
In-Reply-To: <CADjXwjhvb9BVNPjY2f-4yfE51RGL88U3VbiN_gwaMSGbagzQEg@mail.gmail.com>

Hello,

On Thu, 2021-08-05 at 13:17 -0700, Coco Li wrote:
> > Have you considered additionally run the same test of top of a veth
> > pair, and have such tests always enabled, so we could have some
> > coverage regardless of specific H/W available?
> 
> > To do the above you should disable TSO on the veth sender peer and
> > enable GRO on the other end.
> 
> Thanks for the suggestion! To make sure I understand you correctly,
> would this be another script that creates the veth pair separate from
> the gro.sh wrapper?

I personally don't have any strict preference. I *think* the veth
thing could still fit the gro.sh script, but whatever is easier coding
wise would fit. 

The gro.sh script with no/default argument could run all the tests on a
veth pair; if a device name is specified via the command line, it could
additionally run (the specified set of tests) on such device.

Cheers,

Paolo




  parent reply	other threads:[~2021-08-06  7:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05  7:36 [PATCH net-next 0/2] GRO and Toeplitz hash selftests Coco Li
2021-08-05  7:36 ` [PATCH net-next 1/2] selftests/net: GRO coalesce test Coco Li
2021-08-05 11:16   ` Paolo Abeni
2021-08-05 20:21     ` Coco Li
     [not found]     ` <CADjXwjhvb9BVNPjY2f-4yfE51RGL88U3VbiN_gwaMSGbagzQEg@mail.gmail.com>
2021-08-06  7:49       ` Paolo Abeni [this message]
2021-08-06 17:44         ` Coco Li
2021-08-05  7:36 ` [PATCH net-next 2/2] selftests/net: toeplitz test Coco Li
2021-08-05 12:30 ` [PATCH net-next 0/2] GRO and Toeplitz hash selftests patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dea381f16949a076860a550ae1db91dcca935f8f.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=lixiaoyan@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=tannerlove@google.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).