From: Suman Anna <s-anna@ti.com>
To: Grygorii Strashko <grygorii.strashko@ti.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, Sekhar Nori <nsekhar@ti.com>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during suspend
Date: Fri, 22 May 2020 11:50:40 -0500 [thread overview]
Message-ID: <df01fb0e-940f-f14a-aba0-670f3b61d3f8@ti.com> (raw)
In-Reply-To: <20200522163931.29905-1-grygorii.strashko@ti.com>
On 5/22/20 11:39 AM, Grygorii Strashko wrote:
> vlan_for_each() are required to be called with rtnl_lock taken, otherwise
> ASSERT_RTNL() warning will be triggered - which happens now during System
> resume from suspend:
> cpsw_suspend()
> |- cpsw_ndo_stop()
> |- __hw_addr_ref_unsync_dev()
> |- cpsw_purge_all_mc()
> |- vlan_for_each()
> |- ASSERT_RTNL();
>
> Hence, fix it by surrounding cpsw_ndo_stop() by rtnl_lock/unlock() calls.
>
> Fixes: 15180eca569b net: ethernet: ti: cpsw: fix vlan mcast
Format for this should be
Fixes: 15180eca569b ("net: ethernet: ti: cpsw: fix vlan mcast")
regards
Suman
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/net/ethernet/ti/cpsw.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index c2c5bf87da01..ffeb8633e530 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -1753,11 +1753,15 @@ static int cpsw_suspend(struct device *dev)
> struct cpsw_common *cpsw = dev_get_drvdata(dev);
> int i;
>
> + rtnl_lock();
> +
> for (i = 0; i < cpsw->data.slaves; i++)
> if (cpsw->slaves[i].ndev)
> if (netif_running(cpsw->slaves[i].ndev))
> cpsw_ndo_stop(cpsw->slaves[i].ndev);
>
> + rtnl_unlock();
> +
> /* Select sleep pin state */
> pinctrl_pm_select_sleep_state(dev);
>
>
next prev parent reply other threads:[~2020-05-22 16:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 16:39 [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during suspend Grygorii Strashko
2020-05-22 16:50 ` Suman Anna [this message]
2020-05-22 17:08 ` Grygorii Strashko
2020-05-23 23:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df01fb0e-940f-f14a-aba0-670f3b61d3f8@ti.com \
--to=s-anna@ti.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).