From: Heiner Kallweit <hkallweit1@gmail.com>
To: Vincas Dargis <vindrg@gmail.com>,
Salvatore Bonaccorso <carnil@debian.org>
Cc: netdev@vger.kernel.org
Subject: Re: About r8169 regression 5.4
Date: Mon, 17 Feb 2020 20:59:46 +0100 [thread overview]
Message-ID: <e0c43868-8201-fe46-9e8b-5e38c2611340@gmail.com> (raw)
In-Reply-To: <81548409-2fd3-9645-eeaf-ab8f7789b676@gmail.com>
On 17.02.2020 19:08, Vincas Dargis wrote:
> 2020-02-16 01:27, Heiner Kallweit rašė:
>> One more idea:
>> Commit "r8169: enable HW csum and TSO" enables certain hardware offloading by default.
>> Maybe your chip version has a hw issue with offloading. You could try:
>>
>> 1. Disable TSO
>> ethtool -K <if> tso off
>>
>> 2. If this didn't help, disable all offloading.
>> ethtool -K <if> tx off sg off tso off
>>
>
> Unmodified 5.4 was running successfully for whole Sunday with `tx off sg off tso off`! Disabling only tso did not help, while disabling all actually avoided the timeout.
>
Great, thanks a lot for testing! Then the bisecting shouldn't be needed. Since 5.4 these features are enabled by default,
up to 5.3 they are available but have to be enabled explicitly. This should explain the observed behavior.
So it looks like this chip version has a hw issue with tx checksumming. I contacted Realtek to see whether
they are aware of any such hw issue. Depending on their feedback we may have to add a quirk for this chip version
to not enable these features by default.
> I've attached kern.log from boot 'til 5.4 got that timeout (when I did not use these off's).
>
> About bisecting - I need to figure out how to build linux-image and linux-headers package only, to reduce that almost hour build...
next prev parent reply other threads:[~2020-02-17 19:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 17:21 About r8169 regression 5.4 Vincas Dargis
2020-02-14 20:14 ` Heiner Kallweit
2020-02-15 9:22 ` Vincas Dargis
2020-02-15 16:12 ` Salvatore Bonaccorso
2020-02-15 21:10 ` Vincas Dargis
2020-02-15 22:07 ` Vincas Dargis
2020-02-15 22:35 ` Heiner Kallweit
2020-02-15 23:27 ` Heiner Kallweit
2020-02-17 18:08 ` Vincas Dargis
2020-02-17 19:59 ` Heiner Kallweit [this message]
2020-02-18 18:36 ` Vincas Dargis
2020-02-19 21:54 ` Heiner Kallweit
2020-02-20 17:36 ` Vincas Dargis
2020-02-20 18:32 ` Heiner Kallweit
2020-02-21 20:21 ` Vincas Dargis
2020-02-21 21:01 ` Heiner Kallweit
2020-02-23 13:24 ` Vincas Dargis
2020-02-23 13:27 ` Heiner Kallweit
2020-02-24 19:49 ` Heiner Kallweit
2020-02-27 18:25 ` Vincas Dargis
2020-04-12 11:56 ` Lauri Jakku
2020-04-12 12:02 ` Lauri Jakku
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0c43868-8201-fe46-9e8b-5e38c2611340@gmail.com \
--to=hkallweit1@gmail.com \
--cc=carnil@debian.org \
--cc=netdev@vger.kernel.org \
--cc=vindrg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).