From: Paolo Abeni <pabeni@redhat.com>
To: Gerhard Engleder <gerhard@engleder-embedded.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
bjorn@kernel.org, magnus.karlsson@intel.com,
maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com
Subject: Re: [PATCH net-next v2 6/6] tsnep: Add XDP socket zero-copy TX support
Date: Tue, 18 Apr 2023 10:27:08 +0200 [thread overview]
Message-ID: <e4309e95bc98ff2d464dd26fc4f3e77a914a6cb5.camel@redhat.com> (raw)
In-Reply-To: <20230415144256.27884-7-gerhard@engleder-embedded.com>
On Sat, 2023-04-15 at 16:42 +0200, Gerhard Engleder wrote:
> Send and complete XSK pool frames within TX NAPI context. NAPI context
> is triggered by ndo_xsk_wakeup.
>
> Test results with A53 1.2GHz:
>
> xdpsock txonly copy mode:
> pps pkts 1.00
> tx 284,409 11,398,144
> Two CPUs with 100% and 10% utilization.
>
> xdpsock txonly zero-copy mode:
> pps pkts 1.00
> tx 511,929 5,890,368
> Two CPUs with 100% and 1% utilization.
>
> Packet rate increases and CPU utilization is reduced.
>
> Signed-off-by: Gerhard Engleder <gerhard@engleder-embedded.com>
> ---
> drivers/net/ethernet/engleder/tsnep.h | 2 +
> drivers/net/ethernet/engleder/tsnep_main.c | 131 +++++++++++++++++++--
> 2 files changed, 123 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ethernet/engleder/tsnep.h b/drivers/net/ethernet/engleder/tsnep.h
> index d0bea605a1d1..11b29f56aaf9 100644
> --- a/drivers/net/ethernet/engleder/tsnep.h
> +++ b/drivers/net/ethernet/engleder/tsnep.h
> @@ -70,6 +70,7 @@ struct tsnep_tx_entry {
> union {
> struct sk_buff *skb;
> struct xdp_frame *xdpf;
> + bool zc;
> };
> size_t len;
> DEFINE_DMA_UNMAP_ADDR(dma);
> @@ -88,6 +89,7 @@ struct tsnep_tx {
> int read;
> u32 owner_counter;
> int increment_owner_counter;
> + struct xsk_buff_pool *xsk_pool;
>
> u32 packets;
> u32 bytes;
> diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
> index 13e5d4438082..de51d0cc8935 100644
> --- a/drivers/net/ethernet/engleder/tsnep_main.c
> +++ b/drivers/net/ethernet/engleder/tsnep_main.c
> @@ -54,6 +54,8 @@
> #define TSNEP_TX_TYPE_SKB_FRAG BIT(1)
> #define TSNEP_TX_TYPE_XDP_TX BIT(2)
> #define TSNEP_TX_TYPE_XDP_NDO BIT(3)
> +#define TSNEP_TX_TYPE_XDP (TSNEP_TX_TYPE_XDP_TX | TSNEP_TX_TYPE_XDP_NDO)
> +#define TSNEP_TX_TYPE_XSK BIT(4)
>
> #define TSNEP_XDP_TX BIT(0)
> #define TSNEP_XDP_REDIRECT BIT(1)
> @@ -322,13 +324,51 @@ static void tsnep_tx_init(struct tsnep_tx *tx)
> tx->increment_owner_counter = TSNEP_RING_SIZE - 1;
> }
>
> +static void tsnep_tx_enable(struct tsnep_tx *tx)
> +{
> + struct netdev_queue *nq;
> +
> + nq = netdev_get_tx_queue(tx->adapter->netdev, tx->queue_index);
> +
> + local_bh_disable();
> + __netif_tx_lock(nq, smp_processor_id());
The above 2 statements could be replaced with:
__netif_tx_lock_bh()
> + netif_tx_wake_queue(nq);
> + __netif_tx_unlock(nq);
> + local_bh_enable();
__netif_tx_unlock_bh()
> +}
> +
> +static void tsnep_tx_disable(struct tsnep_tx *tx, struct napi_struct *napi)
> +{
> + struct netdev_queue *nq;
> + u32 val;
> +
> + nq = netdev_get_tx_queue(tx->adapter->netdev, tx->queue_index);
> +
> + local_bh_disable();
> + __netif_tx_lock(nq, smp_processor_id());
Same here.
Thanks!
Paolo
next prev parent reply other threads:[~2023-04-18 8:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 14:42 [PATCH net-next v2 0/6] tsnep: XDP socket zero-copy support Gerhard Engleder
2023-04-15 14:42 ` [PATCH net-next v2 1/6] tsnep: Replace modulo operation with mask Gerhard Engleder
2023-04-15 14:42 ` [PATCH net-next v2 2/6] tsnep: Rework TX/RX queue initialization Gerhard Engleder
2023-04-15 14:42 ` [PATCH net-next v2 3/6] tsnep: Add functions for queue enable/disable Gerhard Engleder
2023-04-15 14:42 ` [PATCH net-next v2 4/6] tsnep: Move skb receive action to separate function Gerhard Engleder
2023-04-15 14:42 ` [PATCH net-next v2 5/6] tsnep: Add XDP socket zero-copy RX support Gerhard Engleder
2023-04-18 8:22 ` Paolo Abeni
2023-04-18 18:41 ` Gerhard Engleder
2023-04-15 14:42 ` [PATCH net-next v2 6/6] tsnep: Add XDP socket zero-copy TX support Gerhard Engleder
2023-04-18 8:27 ` Paolo Abeni [this message]
2023-04-18 18:25 ` Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4309e95bc98ff2d464dd26fc4f3e77a914a6cb5.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerhard@engleder-embedded.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).