From: Doug Berger <opendmb@gmail.com>
To: justinpopo6@gmail.com, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, davem@davemloft.net,
f.fainelli@gmail.com
Subject: Re: [PATCH] net: bcmgenet: use promisc for unsupported filters
Date: Thu, 18 Jul 2019 17:51:21 -0700 [thread overview]
Message-ID: <f54b5a80-4ef2-b531-b247-05ff85d7f219@gmail.com> (raw)
In-Reply-To: <1563400733-39451-1-git-send-email-justinpopo6@gmail.com>
On 7/17/19 2:58 PM, justinpopo6@gmail.com wrote:
> From: Justin Chen <justinpopo6@gmail.com>
>
> Currently we silently ignore filters if we cannot meet the filter
> requirements. This will lead to the MAC dropping packets that are
> expected to pass. A better solution would be to set the NIC to promisc
> mode when the required filters cannot be met.
>
> Also correct the number of MDF filters supported. It should be 17,
> not 16.
>
> Signed-off-by: Justin Chen <justinpopo6@gmail.com>
Acked-by: Doug Berger <opendmb@gmail.com>
Thanks Justin :)
Doug
prev parent reply other threads:[~2019-07-19 0:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 21:58 [PATCH] net: bcmgenet: use promisc for unsupported filters justinpopo6
2019-07-18 3:38 ` Florian Fainelli
2019-07-18 18:46 ` David Miller
2019-07-19 0:51 ` Doug Berger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f54b5a80-4ef2-b531-b247-05ff85d7f219@gmail.com \
--to=opendmb@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=justinpopo6@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).