From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Richard Cochran <richardcochran@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: Kurt Kanzenbach <kurt@linutronix.de>,
Michael Walle <michael@walle.cc>, <davem@davemloft.net>,
<kuba@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux@armlinux.org.uk>, <mlichvar@redhat.com>,
<netdev@vger.kernel.org>, <qiangqing.zhang@nxp.com>,
<vladimir.oltean@nxp.com>
Subject: Re: [PATCH RFC V1 net-next 3/4] net: Let the active time stamping layer be selectable.
Date: Wed, 6 Apr 2022 14:18:38 +0300 [thread overview]
Message-ID: <f8130c2a-f51d-21fd-d999-886ce9559e9c@ti.com> (raw)
In-Reply-To: <20220405154821.GB6509@hoboy.vegasvil.org>
On 05/04/2022 18:48, Richard Cochran wrote:
> On Tue, Apr 05, 2022 at 03:29:05PM +0200, Andrew Lunn wrote:
>
>> Maybe. Device tree is supposed to describe the hardware, not how you
>> configure the hardware. Which PTP you using is a configuration choice,
>> so i expect some people will argue it should not be in DT.
>
> +1
>
> Pure DT means no configuration choices.
>
> (but you find many examples that break the rules!)
>
My point was related to one of issues described by Michael Walle in this thread:
- supporting TS by the PHY may require also additional board support;
- phy_has_hwtstamp() defined statically by PHY drivers without taking into account board design;
- Kconfig option Doesn't really work with generic distro support and not allowed per-port cfg.
So adding smth like "hwtstamp-en" will clear identify that this particular PHY on this particular board
supports time stamping.
(or hwtstamp-full/hwtstamp-rx/hwtstamp-tx).
Of course, it will not help with default or dynamic selection of time stamping layer :(,
but it will be one problem less.
--
Best regards,
Grygorii, Ukraine
next prev parent reply other threads:[~2022-04-06 13:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-03 23:25 [PATCH RFC V1 net-next 3/4] net: Let the active time stamping layer be selectable Richard Cochran
2022-01-03 23:53 ` Russell King (Oracle)
2022-01-04 1:42 ` Richard Cochran
2022-04-04 15:05 ` Michael Walle
2022-04-04 15:20 ` Andrew Lunn
2022-04-04 17:12 ` Michael Walle
2022-04-05 5:59 ` Richard Cochran
2022-04-05 8:48 ` Michael Walle
2022-04-05 15:46 ` Richard Cochran
2022-04-05 9:01 ` Kurt Kanzenbach
2022-04-05 9:19 ` Michael Walle
2022-04-05 11:19 ` Kurt Kanzenbach
2022-04-05 13:15 ` Grygorii Strashko
2022-04-05 13:29 ` Andrew Lunn
2022-04-05 15:48 ` Richard Cochran
2022-04-06 11:18 ` Grygorii Strashko [this message]
2022-01-20 16:48 ` Vladimir Oltean
2022-01-21 3:38 ` Andrew Lunn
2022-01-21 4:05 ` Richard Cochran
2022-01-21 14:50 ` Vladimir Oltean
2022-01-21 15:28 ` Richard Cochran
2022-01-21 16:23 ` Vladimir Oltean
2022-01-22 2:08 ` Richard Cochran
2022-01-24 9:28 ` Miroslav Lichvar
2022-01-24 15:37 ` Richard Cochran
2022-01-25 15:37 ` Vladimir Oltean
2022-01-21 11:05 ` Kurt Kanzenbach
2022-01-21 15:31 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8130c2a-f51d-21fd-d999-886ce9559e9c@ti.com \
--to=grygorii.strashko@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=richardcochran@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).