netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Karuna Grewal <karunagrewal98@gmail.com>
Cc: fw@strlen.de, netfilter-devel@vger.kernel.org
Subject: Re: [nftables] tests/py: Add Test for `meta time`
Date: Tue, 9 Apr 2019 00:35:51 +0200	[thread overview]
Message-ID: <20190408223551.sqzjaucb6jyegyci@salvia> (raw)
In-Reply-To: <20190318094745.GA4394@nebula>

On Mon, Mar 18, 2019 at 03:17:45PM +0530, Karuna Grewal wrote:
> Signed-off-by: Karuna Grewal <karunagrewal98@gmail.com>
> ---
>  tests/py/any/meta.t         |  3 +++
>  tests/py/any/meta.t.json    | 12 ++++++++++++
>  tests/py/any/meta.t.payload |  5 +++++
>  3 files changed, 20 insertions(+)
> 
> diff --git a/tests/py/any/meta.t b/tests/py/any/meta.t
> index d69b8b4e..3d23dc75 100644
> --- a/tests/py/any/meta.t
> +++ b/tests/py/any/meta.t
> @@ -205,3 +205,6 @@ meta iif . meta oif vmap { "lo" . "lo" : drop };ok;iif . oif vmap { "lo" . "lo"
>  
>  meta random eq 1;ok;meta random 1
>  meta random gt 1000000;ok;meta random > 1000000
> +
> +meta time 100;ok;meta timestamp 1m40s

I think the important thing here is to support for dates.

I remember Florian mentioned we need a new datatype for this, to
express dates.

Still we need support for time range, ie. hh:mm[:ss]-hh:mm[:ss],
monthdays and weekdays.

We should _not_ support --kerneltz, that broken. We should just
provide an alternative that works with UTC. Hopefully daylight saving
will be removed everywhere soon (EU is planning for this), so we won't
need --kerneltz.

Talking by looking at what I see in man iptables-extensions when I
look for the `time' match.

Will you work on this?

      parent reply	other threads:[~2019-04-08 22:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18  9:47 [nftables] tests/py: Add Test for `meta time` Karuna Grewal
     [not found] ` <CAHRz_yZMsP2RQPu=8pTigq8SrYz9xYSef3S_d4ORAMkkYDEv4Q@mail.gmail.com>
     [not found]   ` <20190318105545.qz5oddbjah4qc4fa@breakpoint.cc>
     [not found]     ` <CAHRz_yYk_Yq5+Tp1J1jT2rVT0pHWjH37-F8Rdi1XCLWj79J6rg@mail.gmail.com>
     [not found]       ` <20190318220923.5v64yccan6shhpnq@breakpoint.cc>
2019-03-19  7:04         ` Karuna Grewal
2019-03-19  7:17           ` Florian Westphal
2019-03-19  7:27             ` Karuna Grewal
2019-03-19  7:50               ` Florian Westphal
2019-04-08 22:35 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190408223551.sqzjaucb6jyegyci@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=karunagrewal98@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).