From: Florian Westphal <fw@strlen.de>
To: Fernando Fernandez Mancera <ffmancera@riseup.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 4/5 nf-next] netfilter: synproxy: extract IPv6 SYNPROXY infrastructure from ip6t_SYNPROXY
Date: Sat, 18 May 2019 22:20:32 +0200 [thread overview]
Message-ID: <20190518202032.2bjv4e547kli56c6@breakpoint.cc> (raw)
In-Reply-To: <20190518182151.1231-5-ffmancera@riseup.net>
Fernando Fernandez Mancera <ffmancera@riseup.net> wrote:
Hi Fernando
> +void
> +synproxy_send_client_synack_ipv6(struct net *net,
> + const struct sk_buff *skb,
> + const struct tcphdr *th,
> + const struct synproxy_options *opts)
[..]
> + nth->seq = htonl(__cookie_v6_init_sequence(iph, th, &mss));
It seems that __cookie_v6_init_sequence() is the only dependency of
this module on ipv6.
If we would make it accessible via nf_ipv6_ops struct, then the
dependency goes away and we could place ipv4 and ipv6 parts in a
single module.
Just saying, it would avoid adding extra modules.
We could then have
nf_synproxy.ko # shared code
nft_synproxy.ko # nftables frontend
xt_SYNPROXY.ko # ip(6)tables frontends
next prev parent reply other threads:[~2019-05-18 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-18 18:21 [PATCH 0/5] Extract SYNPROXY infrastructure Fernando Fernandez Mancera
2019-05-18 18:21 ` [PATCH 1/5 nf-next] netfilter: synproxy: add common uapi for " Fernando Fernandez Mancera
2019-05-18 18:21 ` [PATCH 2/5 nf-next] netfilter: synproxy: extract IPv4 SYNPROXY infrastructure from ipt_SYNPROXY Fernando Fernandez Mancera
2019-05-18 18:21 ` [PATCH 3/5 nf-next] netfilter: add NF_SYNPROXY_IPV4 symbol Fernando Fernandez Mancera
2019-05-18 18:21 ` [PATCH 4/5 nf-next] netfilter: synproxy: extract IPv6 SYNPROXY infrastructure from ip6t_SYNPROXY Fernando Fernandez Mancera
2019-05-18 20:20 ` Florian Westphal [this message]
2019-05-18 20:38 ` Fernando Fernandez Mancera
2019-05-18 20:45 ` Florian Westphal
2019-05-18 18:21 ` [PATCH 5/5 nf-next] netfilter: add NF_SYNPROXY_IPV6 symbol Fernando Fernandez Mancera
2019-05-18 19:29 ` [PATCH 0/5] Extract SYNPROXY infrastructure Jan Engelhardt
2019-05-19 21:03 ` Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190518202032.2bjv4e547kli56c6@breakpoint.cc \
--to=fw@strlen.de \
--cc=ffmancera@riseup.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).