From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: marcmicalizzi@gmail.com, Florian Westphal <fw@strlen.de>
Subject: [PATCH nf 1/5] netfilter: nf_flow_table: ignore DF bit setting
Date: Tue, 21 May 2019 13:24:30 +0200 [thread overview]
Message-ID: <20190521112434.11767-2-fw@strlen.de> (raw)
In-Reply-To: <20190521112434.11767-1-fw@strlen.de>
Its irrelevant if the DF bit is set or not, we must pass packet to
stack in either case.
If the DF bit is set, we must pass it to stack so the appropriate
ICMP error can be generated.
If the DF is not set, we must pass it to stack for fragmentation.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
net/netfilter/nf_flow_table_ip.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c
index 0d603e20b519..bfd44db9f214 100644
--- a/net/netfilter/nf_flow_table_ip.c
+++ b/net/netfilter/nf_flow_table_ip.c
@@ -243,8 +243,7 @@ nf_flow_offload_ip_hook(void *priv, struct sk_buff *skb,
rt = (struct rtable *)flow->tuplehash[dir].tuple.dst_cache;
outdev = rt->dst.dev;
- if (unlikely(nf_flow_exceeds_mtu(skb, flow->tuplehash[dir].tuple.mtu)) &&
- (ip_hdr(skb)->frag_off & htons(IP_DF)) != 0)
+ if (unlikely(nf_flow_exceeds_mtu(skb, flow->tuplehash[dir].tuple.mtu)))
return NF_ACCEPT;
if (skb_try_make_writable(skb, sizeof(*iph)))
--
2.21.0
next prev parent reply other threads:[~2019-05-21 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 11:24 [PATCH nf 0/5] netfilter: flow table fixes Florian Westphal
2019-05-21 11:24 ` Florian Westphal [this message]
2019-05-21 11:24 ` [PATCH nf 2/5] netfilter: nft_flow_offload: set liberal tracking mode for tcp Florian Westphal
2019-05-21 11:24 ` [PATCH nf 3/5] netfilter: nft_flow_offload: don't offload when sequence numbers need adjustment Florian Westphal
2019-05-21 11:24 ` [PATCH nf 4/5] netfilter: nft_flow_offload: IPCB is only valid for ipv4 family Florian Westphal
2019-05-21 11:24 ` [PATCH nf 5/5] selftests: netfilter: add flowtable test script Florian Westphal
2019-05-22 8:55 ` [PATCH nf 0/5] netfilter: flow table fixes Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521112434.11767-2-fw@strlen.de \
--to=fw@strlen.de \
--cc=marcmicalizzi@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).