From: Eric Garver <eric@garver.life>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v2 3/3] src: Restore local entries after cache update
Date: Fri, 24 May 2019 16:30:26 -0400 [thread overview]
Message-ID: <20190524203026.7sghf4mw5tknuajr@egarver.localdomain> (raw)
In-Reply-To: <20190522194406.16827-4-phil@nwl.cc>
On Wed, May 22, 2019 at 09:44:06PM +0200, Phil Sutter wrote:
> When batching up multiple commands, one may run into a situation where
> the current command requires a cache update while the previous ones
> didn't and that causes objects added by previous commands to be removed
> from cache. If the current or any following command references any of
> these objects, the command is rejected.
>
> Resolve this by copying Florian's solution from iptables-nft: After
> droping the whole cache and populating it again with entries fetched
> from kernel, use the current list of commands to restore local entries
> again.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
Acked-by: Eric Garver <eric@garver.life>
prev parent reply other threads:[~2019-05-24 20:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 19:44 [nft PATCH v2 0/3] Resolve cache update woes Phil Sutter
2019-05-22 19:44 ` [nft PATCH v2 1/3] src: update cache if cmd is more specific Phil Sutter
2019-05-24 16:58 ` Pablo Neira Ayuso
2019-05-22 19:44 ` [nft PATCH v2 2/3] libnftables: Keep list of commands in nft context Phil Sutter
2019-05-24 20:30 ` Eric Garver
2019-05-22 19:44 ` [nft PATCH v2 3/3] src: Restore local entries after cache update Phil Sutter
2019-05-24 20:30 ` Eric Garver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190524203026.7sghf4mw5tknuajr@egarver.localdomain \
--to=eric@garver.life \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).