From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: charles@ccxtechnologies.com
Subject: [PATCH nft] evaluate: bogus error when refering to existing non-base chain
Date: Tue, 16 Jul 2019 13:51:20 +0200 [thread overview]
Message-ID: <20190716115120.21710-1-pablo@netfilter.org> (raw)
add rule ip testNEW test6 jump test8
^^^^^
Error: invalid verdict chain expression value
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
src/evaluate.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/src/evaluate.c b/src/evaluate.c
index f95f42e1067a..cd566e856a11 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -1984,17 +1984,9 @@ static int stmt_evaluate_verdict(struct eval_ctx *ctx, struct stmt *stmt)
case EXPR_VERDICT:
if (stmt->expr->verdict != NFT_CONTINUE)
stmt->flags |= STMT_F_TERMINAL;
- if (stmt->expr->chain != NULL) {
- if (expr_evaluate(ctx, &stmt->expr->chain) < 0)
- return -1;
- if ((stmt->expr->chain->etype != EXPR_SYMBOL &&
- stmt->expr->chain->etype != EXPR_VALUE) ||
- stmt->expr->chain->symtype != SYMBOL_VALUE) {
- return stmt_error(ctx, stmt,
- "invalid verdict chain expression %s\n",
- expr_name(stmt->expr->chain));
- }
- }
+ if (stmt->expr->chain != NULL &&
+ expr_evaluate(ctx, &stmt->expr->chain) < 0)
+ return -1;
break;
case EXPR_MAP:
break;
--
2.11.0
next reply other threads:[~2019-07-16 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 11:51 Pablo Neira Ayuso [this message]
2019-07-16 16:47 ` [PATCH nft] evaluate: bogus error when refering to existing non-base chain Phil Sutter
2019-07-16 17:29 ` Fernando Fernandez Mancera
2019-07-16 18:00 ` Florian Westphal
2019-07-16 18:12 ` Pablo Neira Ayuso
2019-07-16 18:26 ` Pablo Neira Ayuso
2019-07-16 18:27 ` Florian Westphal
2019-07-16 18:30 ` Fernando Fernandez Mancera
2019-07-16 22:29 ` Fernando Fernandez Mancera
2019-07-16 17:57 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716115120.21710-1-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=charles@ccxtechnologies.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).