netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: json_cmd_assoc and cmd
Date: Tue, 16 Jul 2019 21:02:24 +0200	[thread overview]
Message-ID: <20190716190224.GB31548@orbyte.nwl.cc> (raw)
In-Reply-To: <20190716183101.pev5gcmk3agqwpsm@salvia>

Hi Pablo,

On Tue, Jul 16, 2019 at 08:31:01PM +0200, Pablo Neira Ayuso wrote:
> Why json_cmd_assoc is not placed in struct cmd instead? I mean, just
> store the json_t *json in cmd?

The global list (json_cmd_list) is used in json_events_cb(). Unless I
miss something, the cmd list is not available from struct
netlink_mon_handler.

Maybe I could move struct cmds list head into struct nft_ctx?

Thanks, Phil

  reply	other threads:[~2019-07-16 19:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16 18:31 json_cmd_assoc and cmd Pablo Neira Ayuso
2019-07-16 19:02 ` Phil Sutter [this message]
2019-07-16 19:39   ` Pablo Neira Ayuso
2019-07-18 12:37     ` Jeremy Sowden
2019-07-18 14:11       ` Phil Sutter
2019-07-18 14:57       ` Pablo Neira Ayuso
2019-07-18 15:07         ` Jeremy Sowden
2019-07-18 21:05         ` [PATCH nft] libnftables: got rid of repeated initialization of netlink_ctx variable in loop Jeremy Sowden
2019-07-19 10:32           ` Phil Sutter
2019-07-19 11:10             ` [PATCH nft v2 0/2] netlink_ctx initialization fixes Jeremy Sowden
2019-07-19 11:10               ` [PATCH nft v2 1/2] libnftables: got rid of repeated initialization of netlink_ctx variable in loop Jeremy Sowden
2019-07-19 11:17                 ` Phil Sutter
2019-07-19 11:10               ` [PATCH nft v2 2/2] rule: removed duplicate member initializer Jeremy Sowden
2019-07-19 11:17                 ` Phil Sutter
2019-07-22 21:29               ` [PATCH nft v2 0/2] netlink_ctx initialization fixes Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190716190224.GB31548@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).