From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [nf PATCH RFC] net: nf_tables: Support auto-loading inet family nat chain
Date: Wed, 17 Jul 2019 22:11:32 +0200 [thread overview]
Message-ID: <20190717201132.GI31548@orbyte.nwl.cc> (raw)
In-Reply-To: <20190717183515.yym6aageq3d3imlu@salvia>
Hi,
On Wed, Jul 17, 2019 at 08:35:15PM +0200, Pablo Neira Ayuso wrote:
[...]
> Please, use (2, "nat") instead like in other extensions.
>
> MODULE_ALIAS_NFT_CHAIN(2, "nat"); /* NFPROTO_INET */
I sent a non-RFC patch which uses fixed value 1. Thanks for the
suggestion!
> Yes, it's not nice, but this is so far what we have.
>
> I agree we should fix this, problem is that NFPROTO_* are enum, and
> IIRC this doesn't mix well with the existing macros.
Ah, right. The __stringify() thing bites us then. In order to use
NFPROTO_* names, those would have to be redefined as macro. And not just
like netinet/in.h does for IPPROTO_* names but with actual value.
Cheers, Phil
prev parent reply other threads:[~2019-07-17 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 17:17 [nf PATCH RFC] net: nf_tables: Support auto-loading inet family nat chain Phil Sutter
2019-07-17 18:35 ` Pablo Neira Ayuso
2019-07-17 20:11 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717201132.GI31548@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).