From: Florian Westphal <fw@strlen.de>
To: <netfilter-devel@vger.kernel.org>
Cc: Florian Westphal <fw@strlen.de>
Subject: [PATCH RFC nft] src: avoid re-initing core library when a second context struct is allocated
Date: Mon, 5 Aug 2019 23:49:17 +0200 [thread overview]
Message-ID: <20190805214917.13747-1-fw@strlen.de> (raw)
Calling nft_ctx_new() a second time leaks memory, and calling
nft_ctx_free a second time -- on a different context -- causes
double-free.
This patch won't work in case we assume libnftables should be
thread-safe, in such case we either need a mutex or move all resources
under nft_ctx scope.
Signed-off-by: Florian Westphal <fw@strlen.de>
---
src/libnftables.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/libnftables.c b/src/libnftables.c
index 4a139c58b2b3..880fd4284555 100644
--- a/src/libnftables.c
+++ b/src/libnftables.c
@@ -17,6 +17,8 @@
#include <stdlib.h>
#include <string.h>
+static unsigned int context_count;
+
static int nft_netlink(struct nft_ctx *nft,
struct list_head *cmds, struct list_head *msgs,
struct mnl_socket *nf_sock)
@@ -86,6 +88,9 @@ out:
static void nft_init(void)
{
+ if (context_count++)
+ return;
+
mark_table_init();
realm_table_rt_init();
devgroup_table_init();
@@ -99,6 +104,9 @@ static void nft_init(void)
static void nft_exit(void)
{
+ if (--context_count)
+ return;
+
ct_label_table_exit();
realm_table_rt_exit();
devgroup_table_exit();
--
2.21.0
next reply other threads:[~2019-08-05 21:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 21:49 Florian Westphal [this message]
2019-08-07 22:41 ` [PATCH RFC nft] src: avoid re-initing core library when a second context struct is allocated Pablo Neira Ayuso
2019-08-07 23:37 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805214917.13747-1-fw@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).