From: Florian Westphal <fw@strlen.de>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [RFC 1/1] nft: abort cache creation if mnl_genid_get fails
Date: Wed, 21 Aug 2019 13:13:58 +0200 [thread overview]
Message-ID: <20190821111358.GB13057@breakpoint.cc> (raw)
In-Reply-To: <20190821075611.30918-2-christian.ehrhardt@canonical.com>
Christian Ehrhardt <christian.ehrhardt@canonical.com> wrote:
> mnl_genid_get can fail and in this case not update the genid which leads
> to a busy loop that never recovers.
>
> To avoid that check the return value and abort __nft_build_cache
> if mnl_genid_get fails.
mnl_genid_get() aborts in case there is an error from mnl_talk in
iptables.git master branch.
See
commit e5cab728c40be88c541f68e4601d39178c36111f
nft: exit in case we can't fetch current genid
So I don't think this change is needed.
In the reported case this happened when calling iptables with
non-root user.
next prev parent reply other threads:[~2019-08-21 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 7:56 [RFC 0/1] avoid busy loop in __nft_build_cache Christian Ehrhardt
2019-08-21 7:56 ` [RFC 1/1] nft: abort cache creation if mnl_genid_get fails Christian Ehrhardt
2019-08-21 11:13 ` Florian Westphal [this message]
2019-08-21 12:56 ` Christian Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821111358.GB13057@breakpoint.cc \
--to=fw@strlen.de \
--cc=christian.ehrhardt@canonical.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).