From: Pablo Neira Ayuso <pablo@netfilter.org>
To: wenxu@ucloud.cn
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf-next v3 3/4] netfilter: nf_tables_offload: add nft_offload_netdev_iterate function
Date: Fri, 6 Sep 2019 02:34:12 +0200 [thread overview]
Message-ID: <20190906003412.eftkpvvhqedmq3de@salvia> (raw)
In-Reply-To: <1567656019-6881-4-git-send-email-wenxu@ucloud.cn>
On Thu, Sep 05, 2019 at 12:00:18PM +0800, wenxu@ucloud.cn wrote:
[...]
> +static void nft_indr_block_cb(struct net_device *dev,
> + flow_indr_block_bind_cb_t *cb, void *cb_priv,
> + enum flow_block_command cmd)
> +{
> + struct net *net = dev_net(dev);
> + struct nft_chain *chain;
> +
> + mutex_lock(&net->nft.commit_mutex);
> + chain = nft_offload_netdev_iterate(dev);
Ah, right, not an interator. Probably __nft_offload_get_basechain(dev) ?
The initial __nft_... suggests the reader that the mutex is required.
> + if (chain) {
> + struct nft_base_chain *basechain;
> +
> + basechain = nft_base_chain(chain);
> + nft_indr_block_ing_cmd(dev, basechain, cb, cb_priv, cmd);
> + }
> mutex_unlock(&net->nft.commit_mutex);
> }
>
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2019-09-06 0:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 4:00 [PATCH nf-next v3 0/4] netfilter: nf_tables_offload: clean offload things when the device unregister wenxu
2019-09-05 4:00 ` [PATCH nf-next v3 1/4] netfilter: nf_tables_offload: refactor the nft_flow_offload_chain function wenxu
2019-09-05 4:00 ` [PATCH nf-next v3 2/4] netfilter: nf_tables_offload: refactor the nft_flow_offload_rule function wenxu
2019-09-05 4:00 ` [PATCH nf-next v3 3/4] netfilter: nf_tables_offload: add nft_offload_netdev_iterate function wenxu
2019-09-06 0:34 ` Pablo Neira Ayuso [this message]
2019-09-06 3:25 ` wenxu
2019-09-05 4:00 ` [PATCH nf-next v3 4/4] netfilter: nf_tables_offload: clean offload things when the device unregister wenxu
2019-09-06 0:27 ` [PATCH nf-next v3 0/4] " Pablo Neira Ayuso
2019-09-06 3:09 ` wenxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906003412.eftkpvvhqedmq3de@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).