From: Michal Kubecek <mkubecek@suse.cz>
To: netfilter-devel@vger.kernel.org
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, Florian Westphal <fw@strlen.de>
Subject: Re: userspace conntrack helper and confirming the master conntrack
Date: Wed, 11 Sep 2019 10:17:10 +0200 [thread overview]
Message-ID: <20190911081710.GD24779@unicorn.suse.cz> (raw)
In-Reply-To: <20190910232426.4ccs7jo7jwhni7az@salvia>
On Wed, Sep 11, 2019 at 01:24:26AM +0200, Pablo Neira Ayuso wrote:
> Hi Michal,
>
> On Wed, Sep 04, 2019 at 02:16:51PM +0200, Michal Kubecek wrote:
> > This seems to have fallen through the cracks. I tried to do the revert
> > but it's not completely straightforward as bridge conntrack has been
> > introduced in between and I'm not sure I got the bridge part right.
> > Could someone more familiar with the code take a look?
>
> I'm exploring a different path, see attached patch (still untested).
>
> I'm trying to avoid this large revert from Florian. The idea with this
> patch is to invoke the conntrack confirmation path from the
> nf_reinject() path, which is what it is missing.
Thank you for looking into it. I'll take a look at your patch.
> I'm at a conference right now, I'll try scratch time to sort out this
> asap. Most likely we'll have to request a patch to be included in
> -stable in the next release I'm afraid.
As the regression didn't happen in this cycle but in 5.1-rc1, there are
already two releases affected so that it's IMHO more important to get it
right than to catch 5.3 at any cost.
Michal
next prev parent reply other threads:[~2019-09-11 8:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 8:49 userspace conntrack helper and confirming the master conntrack Michal Kubecek
2019-07-18 9:21 ` Florian Westphal
2019-07-18 10:18 ` Michal Kubecek
2019-07-19 16:47 ` Pablo Neira Ayuso
2019-09-04 12:16 ` Michal Kubecek
2019-09-10 23:24 ` Pablo Neira Ayuso
2019-09-11 8:17 ` Michal Kubecek [this message]
2020-05-13 17:54 ` Jacob Rasmussen
2020-05-15 14:36 ` Florian Westphal
2020-05-15 14:37 ` [PATCH nf] netfilter: make conntrack userspace helpers work again Florian Westphal
2020-05-15 15:17 ` userspace conntrack helper and confirming the master conntrack Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190911081710.GD24779@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).