From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH libnfnetlink 0/1] Minimally resurrect doxygen documentation
Date: Wed, 16 Oct 2019 09:52:38 +1100 [thread overview]
Message-ID: <20191015225238.GA5350@dimstar.local.net> (raw)
In-Reply-To: <20191014020223.21757-1-duncan_roe@optusnet.com.au>
Hi Pablo,
On Mon, Oct 14, 2019 at 01:02:22PM +1100, Duncan Roe wrote:
> libnfnetlink has good doxygen documentation but there was no output when
> doxygen was run.
>
> Patch 1/1 fixes that,
> but on rebuilding there were a number warnings of the form:
>
> right-hand operand of comma expression has no effect [-Wunused-value]
>
> *This was not introduced by patch 1/1*
>
> Instead, it is caused by the definition of "prefetch" in include/linux_list.h:
>
> #define prefetch(x) 1
>
> the Linux kernel has:
>
> #define prefetch(x) __builtin_prefetch(x)
>
> I see 3 ways to get back to a clean compile:
>
> 1. Suppress the warnings with a pragma
>
> 2. Reinstate the Linux definition of prefetch
>
> 3. Expunge prefetch from the header file
>
> I have made all 3, please indicate which one you'd like.
>
> 1. & 2. are 1-liners while 3. is multiline.
>
> 3. allows of extra simplifications, such as defining a macro in a single
> line or fewer lines than before. In some places I could also delete the fragment
> "&& ({ 1;})".
>
>
> Duncan Roe (1):
> src: Minimally resurrect doxygen documentation
>
> configure.ac | 2 +-
> doxygen.cfg.in | 180 +++++++++++++++++++++++++++++++++++++++++++++++++++
> include/linux_list.h | 9 +++
> src/iftable.c | 9 +++
> src/libnfnetlink.c | 17 ++++-
> 5 files changed, 215 insertions(+), 2 deletions(-)
> create mode 100644 doxygen.cfg.in
>
> --
> 2.14.5
>
Any feedback on this?
Exposing the documentation would be uncontroversial surely?
In regard to compiler warnings, alternative 1 entails least effort to review,
since the code remains unchanged.
Cheers ... Duncan.
prev parent reply other threads:[~2019-10-15 22:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 2:02 [PATCH libnfnetlink 0/1] Minimally resurrect doxygen documentation Duncan Roe
2019-10-14 2:02 ` [PATCH libnfnetlink 1/1] src: " Duncan Roe
2019-10-23 11:13 ` Pablo Neira Ayuso
2019-10-23 15:12 ` Duncan Roe
2019-10-23 15:58 ` Jeremy Sowden
2019-10-23 20:55 ` Pablo Neira Ayuso
2019-10-23 15:31 ` Duncan Roe
2019-10-23 20:48 ` Pablo Neira Ayuso
2019-10-24 23:51 ` Duncan Roe
2019-10-26 7:40 ` Duncan Roe
2019-10-26 11:54 ` Pablo Neira Ayuso
2019-10-26 5:19 ` Duncan Roe
2019-10-26 6:59 ` [PATCH libnfnetlink v2 0/2] " Duncan Roe
2019-10-26 6:59 ` [PATCH libnfnetlink v2 1/2] " Duncan Roe
2019-10-26 6:59 ` [PATCH libnfnetlink v2 2/2] Make it clear that this library is deprecated Duncan Roe
2019-10-27 8:49 ` [PATCH libnfnetlink v3 0/2] Minimally resurrect doxygen documentation Duncan Roe
2019-10-27 8:49 ` [PATCH libnfnetlink v3 1/2] " Duncan Roe
2019-11-04 17:28 ` Pablo Neira Ayuso
2019-10-27 8:49 ` [PATCH libnfnetlink v3 2/2] Make it clear that this library is deprecated Duncan Roe
2019-11-04 17:28 ` Pablo Neira Ayuso
2019-10-15 22:52 ` Duncan Roe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015225238.GA5350@dimstar.local.net \
--to=duncan_roe@optusnet.com.au \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).