netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jeremy Sowden <jeremy@azazel.net>
Cc: Netfilter Devel <netfilter-devel@vger.kernel.org>,
	Sebastian Priebe <sebastian.priebe@de.sii.group>
Subject: Re: [PATCH nftables v2 1/2] cli: add linenoise CLI implementation.
Date: Wed, 16 Oct 2019 14:19:30 +0200	[thread overview]
Message-ID: <20191016121930.ufjztmd7ep4kyq4r@salvia> (raw)
In-Reply-To: <20191016105501.GA5825@azazel.net>

On Wed, Oct 16, 2019 at 11:55:02AM +0100, Jeremy Sowden wrote:
> On 2019-10-15, at 10:32:52 +0200, Pablo Neira Ayuso wrote:
> > On Tue, Sep 24, 2019 at 08:40:54AM +0100, Jeremy Sowden wrote:
> > > By default, continue to use libreadline, but if
> > > `--with-cli=linenoise` is passed to configure, build the linenoise
> > > implementation instead.
> >
> > Applied, thanks Jeremy.
> 
> Thanks, Pablo.  Don't know whether you change your mind about it, but
> there was a second patch with changes to `nft -v` that you suggested:
> 
>   https://lore.kernel.org/netfilter-devel/20190924074055.4146-3-jeremy@azazel.net/
> 
> Need to find something else to do now. :) Will go and have a poke about
> in Bugzilla.

This might be useful:

https://bugzilla.netfilter.org/show_bug.cgi?id=1374

  reply	other threads:[~2019-10-16 12:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-24  7:40 [PATCH nftables v2 0/2] Add Linenoise support to the CLI Jeremy Sowden
2019-09-24  7:40 ` [PATCH nftables v2 1/2] cli: add linenoise CLI implementation Jeremy Sowden
2019-10-15  8:32   ` Pablo Neira Ayuso
2019-10-16 10:55     ` Jeremy Sowden
2019-10-16 12:19       ` Pablo Neira Ayuso [this message]
2019-10-16 13:34         ` Jeremy Sowden
2019-09-24  7:40 ` [PATCH nftables v2 2/2] main: add more information to `nft -v` Jeremy Sowden
2019-09-26  7:35 ` [PATCH nftables v2 0/2] Add Linenoise support to the CLI Phil Sutter
2019-10-15  7:23 ` AW: " Priebe, Sebastian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016121930.ufjztmd7ep4kyq4r@salvia \
    --to=pablo@netfilter.org \
    --cc=jeremy@azazel.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=sebastian.priebe@de.sii.group \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).