From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F85CA9EB7 for ; Wed, 23 Oct 2019 11:23:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 372D62064A for ; Wed, 23 Oct 2019 11:23:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404623AbfJWLXR (ORCPT ); Wed, 23 Oct 2019 07:23:17 -0400 Received: from correo.us.es ([193.147.175.20]:34550 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405059AbfJWLXQ (ORCPT ); Wed, 23 Oct 2019 07:23:16 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 1D422EBAED for ; Wed, 23 Oct 2019 13:23:12 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 0F87BD190C for ; Wed, 23 Oct 2019 13:23:12 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 053E4DA4D0; Wed, 23 Oct 2019 13:23:12 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id B2C74D1929; Wed, 23 Oct 2019 13:23:09 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 23 Oct 2019 13:23:09 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 90A0C41E4804; Wed, 23 Oct 2019 13:23:09 +0200 (CEST) Date: Wed, 23 Oct 2019 13:23:11 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH] nft: Use ARRAY_SIZE() macro in nft_strerror() Message-ID: <20191023112311.qrglbzhqad4vfqvo@salvia> References: <20191018155114.7423-1-phil@nwl.cc> <20191023112024.gd4dqe6qqv46hufe@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023112024.gd4dqe6qqv46hufe@salvia> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Wed, Oct 23, 2019 at 01:20:24PM +0200, Pablo Neira Ayuso wrote: > On Fri, Oct 18, 2019 at 05:51:14PM +0200, Phil Sutter wrote: > > Variable 'table' is an array of type struct table_struct, so this is a > > classical use-case for ARRAY_SIZE() macro. > > > > Signed-off-by: Phil Sutter > > Acked-by: Pablo Neira Ayuso BTW, probably good to add the array check? https://sourceforge.net/p/libhx/libhx/ci/master/tree/include/libHX/defs.h#l152