From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] nft: Use ARRAY_SIZE() macro in nft_strerror()
Date: Thu, 24 Oct 2019 11:51:01 +0200 [thread overview]
Message-ID: <20191024095101.GQ26123@orbyte.nwl.cc> (raw)
In-Reply-To: <20191024092903.sqvoxwwuflk2h4cn@salvia>
Hey,
On Thu, Oct 24, 2019 at 11:29:03AM +0200, Pablo Neira Ayuso wrote:
[...]
> If gcc is already checking for this. Warning should be fine.
>
> Regarding -Werror, we would at least need to keep the autogenerated C
> code by bison away from it.
In nftables there is libparser_la_CFLAGS which holds quite some
exclusions already and could be used to pass -Wno-error as well. (Maybe
a good idea to add this regardless of whether we set -Werror by default
or not.)
> IIRC I enabled this in conntrack-tools long time ago, and I started
> getting reports on it breaking compilation with new gcc versions that
> were actually spewing new warnings. That was stopping users to install
> latest, probably -Werror is too agressive?
Yes, I wasn't completely serious. Breaking users' builds for things they
may not be in control of is not the best idea. We could instead add a
configure option to enable strict mode, but checking for warnings is
something I usually do so probably not that important after all.
Cheers, Phil
next prev parent reply other threads:[~2019-10-24 9:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 15:51 [iptables PATCH] nft: Use ARRAY_SIZE() macro in nft_strerror() Phil Sutter
2019-10-23 11:20 ` Pablo Neira Ayuso
2019-10-23 11:23 ` Pablo Neira Ayuso
2019-10-23 12:16 ` Phil Sutter
2019-10-23 20:41 ` Pablo Neira Ayuso
2019-10-24 8:45 ` Phil Sutter
2019-10-24 9:29 ` Pablo Neira Ayuso
2019-10-24 9:51 ` Phil Sutter [this message]
2019-10-24 10:01 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024095101.GQ26123@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).