From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] tests/py: Fix test script for Python3 tempfile
Date: Tue, 29 Oct 2019 13:07:41 +0100 [thread overview]
Message-ID: <20191029120741.kwx4w7droeqlhqj4@salvia> (raw)
In-Reply-To: <20191029112508.16502-1-phil@nwl.cc>
On Tue, Oct 29, 2019 at 12:25:08PM +0100, Phil Sutter wrote:
> When instantiating a temporary file using tempfile's TemporaryFile()
> constructor, the resulting object's 'name' attribute is of type int.
> This in turn makes print_msg() puke while trying to concatenate string
> and int using '+' operator.
>
> Fix this by using format strings consequently, thereby cleaning up code
> a bit.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2019-10-29 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 11:25 [nft PATCH] tests/py: Fix test script for Python3 tempfile Phil Sutter
2019-10-29 12:07 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029120741.kwx4w7droeqlhqj4@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).