From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, a@juaristi.eus
Subject: Re: [PATCH nft 3/4] tests: add meta time test cases
Date: Tue, 12 Nov 2019 20:35:57 +0100 [thread overview]
Message-ID: <20191112193557.GG19558@breakpoint.cc> (raw)
In-Reply-To: <20191112184439.GB11663@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> Hi,
>
> On Thu, Aug 29, 2019 at 04:09:03PM +0200, Florian Westphal wrote:
> [...]
> > diff --git a/tests/py/any/meta.t.payload b/tests/py/any/meta.t.payload
> > index 1d8426de9632..402caae5cad8 100644
> > --- a/tests/py/any/meta.t.payload
> > +++ b/tests/py/any/meta.t.payload
> [...]
> > +# meta hour "17:00" drop
> > +ip test-ip4 input
> > + [ meta load hour => reg 1 ]
> > + [ cmp eq reg 1 0x0000d2f0 ]
> > + [ immediate reg 0 drop ]
>
> Does this pass for you? I'm getting such warnings:
>
> | 7: WARNING: line 3: 'add rule ip test-ip4 input meta hour "17:00" drop':
> | '[ cmp eq reg 1 0x0000d2f0 ]' mismatches '[ cmp eq reg 1 0x0000e100 ]'
>
> On my system, "17:00" consistently translates into 0xe100.
Argh, DST :-(
We will need to add change the test so nft-test.py runs with a fixed
time zone.
next prev parent reply other threads:[~2019-11-12 19:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 14:09 [PATCH nft 0/4] meta: introduce time/day/hour matching Florian Westphal
2019-08-29 14:09 ` [PATCH nft 1/4] evaluate: New internal helper __expr_evaluate_range Florian Westphal
2019-08-29 14:09 ` [PATCH nft 2/4] meta: Introduce new conditions 'time', 'day' and 'hour' Florian Westphal
2019-08-29 14:09 ` [PATCH nft 3/4] tests: add meta time test cases Florian Westphal
2019-11-12 18:44 ` Phil Sutter
2019-11-12 19:35 ` Florian Westphal [this message]
2019-11-12 21:19 ` Phil Sutter
2019-11-12 21:59 ` Phil Sutter
2019-08-29 14:09 ` [PATCH nft 4/4] src: evaluate: catch invalid 'meta day' values in eval step Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112193557.GG19558@breakpoint.cc \
--to=fw@strlen.de \
--cc=a@juaristi.eus \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).