From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH 2/2] scanner: Extend asteriskstring definition
Date: Fri, 7 Feb 2020 18:31:40 +0100 [thread overview]
Message-ID: <20200207173140.hhqav2g6ckxnibmy@salvia> (raw)
In-Reply-To: <20200206113828.7306-2-phil@nwl.cc>
On Thu, Feb 06, 2020 at 12:38:28PM +0100, Phil Sutter wrote:
> Accept sole escaped asterisks as well as unescaped asterisks if
> surrounded by strings. The latter is merely cosmetic, but literal
> asterisk will help when translating from iptables where asterisk has no
> special meaning.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> src/scanner.l | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/scanner.l b/src/scanner.l
> index 99ee83559d2eb..da9bacee23eb5 100644
> --- a/src/scanner.l
> +++ b/src/scanner.l
> @@ -120,7 +120,7 @@ numberstring ({decstring}|{hexstring})
> letter [a-zA-Z]
> string ({letter}|[_.])({letter}|{digit}|[/\-_\.])*
> quotedstring \"[^"]*\"
> -asteriskstring ({string}\*|{string}\\\*)
> +asteriskstring ({string}\*|{string}\\\*|\\\*|{string}\*{string})
Probably this:
{string}\\\*{string})
instead of:
{string}\*{string})
?
The escaping makes it probably clear that there is no support for
infix wildcard matching?
This asteriskstring rule is falling under the string rule in bison.
This is allowing to use \\\* for log messages too, and elsewhere.
next prev parent reply other threads:[~2020-02-07 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 11:38 [nft PATCH 1/2] doc: nft.8: Mention wildcard interface matching Phil Sutter
2020-02-06 11:38 ` [nft PATCH 2/2] scanner: Extend asteriskstring definition Phil Sutter
2020-02-07 17:31 ` Pablo Neira Ayuso [this message]
2020-02-07 17:59 ` Phil Sutter
2020-02-09 22:21 ` Pablo Neira Ayuso
2020-02-10 11:18 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200207173140.hhqav2g6ckxnibmy@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).