From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH 1/2] nft: Merge nft_*_rule_find() functions
Date: Mon, 18 May 2020 17:15:31 +0200 [thread overview]
Message-ID: <20200518151531.GA2495@salvia> (raw)
In-Reply-To: <20200511133817.11106-1-phil@nwl.cc>
On Mon, May 11, 2020 at 03:38:16PM +0200, Phil Sutter wrote:
> Both ebtables and arptables are fine with using nft_ipv46_rule_find()
> instead of their own implementations. Take the chance and move the
> former into nft.c as a static helper since it is used in a single place,
> only. Then get rid of the callback from family_ops.
LGTM.
prev parent reply other threads:[~2020-05-18 15:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 13:38 [iptables PATCH 1/2] nft: Merge nft_*_rule_find() functions Phil Sutter
2020-05-11 13:38 ` [iptables PATCH 2/2] nft: Drop save_counters callback from family_ops Phil Sutter
2020-05-18 15:15 ` Pablo Neira Ayuso
2020-05-18 15:15 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518151531.GA2495@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).